mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-22 11:41:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR c/63543 (incomplete type error should suppress duplicates)

Browse Source 
PR c/63543
	* c-tree.h (C_TYPE_ERROR_REPORTED): Define.
	* c-typeck.c (build_indirect_ref): Don't print the "dereferencing..."
	error multiple times.  Print the type.

	* gcc.dg/pr63543.c: New test.
	* gcc.dg/array-8.c: Remove dg-error.
	* gcc.dg/pr48552-1.c: Remove and adjust dg-error.
	* gcc.dg/pr48552-2.c: Likewise.

From-SVN: r216414
This commit is contained in:
Marek Polacek 2014-10-17 18:53:35 +00:00 committed by Marek Polacek
parent f406ae1fd6
commit d9b7be2ebd
8 changed files with 49 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/c/ChangeLog
View File

@ -1,3 +1,10 @@
2014-10-17 Marek Polacek <polacek@redhat.com>
PR c/63543
* c-tree.h (C_TYPE_ERROR_REPORTED): Define.
* c-typeck.c (build_indirect_ref): Don't print the "dereferencing..."
error multiple times. Print the type.
2014-10-17 Marek Polacek <polacek@redhat.com>
PR c/63549

3
gcc/c/c-tree.h
View File

@ -56,6 +56,9 @@ along with GCC; see the file COPYING3. If not see
This is used for -Wc++-compat. */
#define C_TYPE_DEFINED_IN_STRUCT(TYPE) TYPE_LANG_FLAG_2 (TYPE)
/* Record whether an "incomplete type" error was given for the type. */
#define C_TYPE_ERROR_REPORTED(TYPE) TYPE_LANG_FLAG_3 (TYPE)
/* Record whether a typedef for type `int' was actually `signed int'. */
#define C_TYPEDEF_EXPLICITLY_SIGNED(EXP) DECL_LANG_FLAG_1 (EXP)

7
gcc/c/c-typeck.c
View File

@ -2378,7 +2378,12 @@ build_indirect_ref (location_t loc, tree ptr, ref_operator errstring)
if (!COMPLETE_OR_VOID_TYPE_P (t) && TREE_CODE (t) != ARRAY_TYPE)
{
error_at (loc, "dereferencing pointer to incomplete type");
if (!C_TYPE_ERROR_REPORTED (TREE_TYPE (ptr)))
{
error_at (loc, "dereferencing pointer to incomplete type "
"%qT", t);
C_TYPE_ERROR_REPORTED (TREE_TYPE (ptr)) = 1;
}
return error_mark_node;
}
if (VOID_TYPE_P (t) && c_inhibit_evaluation_warnings == 0)

8
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,11 @@
2014-10-17 Marek Polacek <polacek@redhat.com>
PR c/63543
* gcc.dg/pr63543.c: New test.
* gcc.dg/array-8.c: Remove dg-error.
* gcc.dg/pr48552-1.c: Remove and adjust dg-error.
* gcc.dg/pr48552-2.c: Likewise.
2014-10-17 Marek Polacek <polacek@redhat.com>
PR c/63549

1
gcc/testsuite/gcc.dg/array-8.c
View File

@ -45,5 +45,4 @@ g (void)
sip[0]; /* { dg-error "invalid use of undefined type 'struct si'" } */
/* { dg-error "dereferencing pointer to incomplete type" "incomplete" { target *-*-* } 45 } */
0[sip]; /* { dg-error "invalid use of undefined type 'struct si'" } */
/* { dg-error "dereferencing pointer to incomplete type" "incomplete" { target *-*-* } 47 } */
}

4
gcc/testsuite/gcc.dg/pr48552-1.c
View File

@ -49,5 +49,5 @@ f7 (struct S *x)
void
f8 (struct S *x)
{
__asm volatile ("" : "=r" (*x)); /* { dg-error "dereferencing pointer to incomplete type" "incomplete" } */
} /* { dg-error "invalid lvalue in asm output 0" "invalid lvalue" { target *-*-* } 52 } */
__asm volatile ("" : "=r" (*x)); /* { dg-error "invalid lvalue in asm output 0" } */
}

4
gcc/testsuite/gcc.dg/pr48552-2.c
View File

@ -49,5 +49,5 @@ f7 (struct S *x)
void
f8 (struct S *x)
{
__asm ("" : "=r" (*x)); /* { dg-error "dereferencing pointer to incomplete type" "incomplete" } */
} /* { dg-error "invalid lvalue in asm output 0" "invalid lvalue" { target *-*-* } 52 } */
__asm ("" : "=r" (*x)); /* { dg-error "invalid lvalue in asm output 0" } */
}

21
gcc/testsuite/gcc.dg/pr63543.c Normal file
View File

@ -0,0 +1,21 @@
/* PR c/63543 */
/* { dg-do compile } */
struct S;
union U;
int
f1 (struct S *s)
{
return s->a /* { dg-error "dereferencing pointer to incomplete type .struct S." } */
+ s->b
+ s->c;
}
int
f2 (union U *u)
{
return u->a /* { dg-error "dereferencing pointer to incomplete type .union U." } */
+ u->a
+ u->a;
}