From d8987adb29b6d98c923d93fcc29ab4d8d47e8a1a Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Thu, 6 Jan 2005 15:22:11 +0000 Subject: [PATCH] re PR c++/19270 (ice on valid template code) cp: PR c++/19270 * pt.c (tsubst_copy) : Handle separately. (tsubst_copy_and_build) : Remove obsolete array-new handling code. Use build_x_binary_op. testsuite: PR c++/19270 * g++.dg/template/array10.C: New. From-SVN: r92992 --- gcc/cp/ChangeLog | 7 +++++++ gcc/cp/pt.c | 23 ++++++++++------------- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/template/array10.C | 20 ++++++++++++++++++++ 4 files changed, 42 insertions(+), 13 deletions(-) create mode 100644 gcc/testsuite/g++.dg/template/array10.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 4f3e21003e8d..fb98595db1fb 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,10 @@ +2005-01-06 Nathan Sidwell + + PR c++/19270 + * pt.c (tsubst_copy) : Handle separately. + (tsubst_copy_and_build) : Remove obsolete + array-new handling code. Use build_x_binary_op. + 2005-01-05 Nathan Sidwell PR c++/19030 diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index f24865e8f108..e6f4b51098f3 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -7869,7 +7869,6 @@ tsubst_copy (tree t, tree args, tsubst_flags_t complain, tree in_decl) case GE_EXPR: case LT_EXPR: case GT_EXPR: - case ARRAY_REF: case COMPOUND_EXPR: case SCOPE_REF: case DOTSTAR_EXPR: @@ -7882,6 +7881,13 @@ tsubst_copy (tree t, tree args, tsubst_flags_t complain, tree in_decl) (code, tsubst_copy (TREE_OPERAND (t, 0), args, complain, in_decl), tsubst_copy (TREE_OPERAND (t, 1), args, complain, in_decl)); + case ARRAY_REF: + return build_nt + (ARRAY_REF, + tsubst_copy (TREE_OPERAND (t, 0), args, complain, in_decl), + tsubst_copy (TREE_OPERAND (t, 1), args, complain, in_decl), + NULL_TREE, NULL_TREE); + case CALL_EXPR: return build_nt (code, tsubst_copy (TREE_OPERAND (t, 0), args, @@ -8526,21 +8532,12 @@ tsubst_copy_and_build (tree t, case SCOPE_REF: return tsubst_qualified_id (t, args, complain, in_decl, /*done=*/true, /*address_p=*/false); - case ARRAY_REF: - if (tsubst_copy (TREE_OPERAND (t, 0), args, complain, in_decl) - == NULL_TREE) - /* new-type-id */ - return build_nt (ARRAY_REF, NULL_TREE, RECUR (TREE_OPERAND (t, 1)), - NULL_TREE, NULL_TREE); - op1 = tsubst_non_call_postfix_expression (TREE_OPERAND (t, 0), args, complain, in_decl); - /* Remember that there was a reference to this entity. */ - if (DECL_P (op1)) - mark_used (op1); - return grok_array_decl (op1, RECUR (TREE_OPERAND (t, 1))); - + return build_x_binary_op (ARRAY_REF, op1, RECUR (TREE_OPERAND (t, 1)), + /*overloaded_p=*/NULL); + case SIZEOF_EXPR: case ALIGNOF_EXPR: op1 = TREE_OPERAND (t, 0); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 63b3ac167dd4..139d695f2ae0 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2005-01-06 Nathan Sidwell + + PR c++/19270 + * g++.dg/template/array10.C: New. + 2005-01-05 Kaveh R. Ghazi * g++.old-deja/g++.pt/asm1.C, g++.old-deja/g++.pt/asm2.C, diff --git a/gcc/testsuite/g++.dg/template/array10.C b/gcc/testsuite/g++.dg/template/array10.C new file mode 100644 index 000000000000..81aac84b0b7e --- /dev/null +++ b/gcc/testsuite/g++.dg/template/array10.C @@ -0,0 +1,20 @@ +// Copyright (C) 2005 Free Software Foundation, Inc. +// Contributed by Nathan Sidwell 5 Jan 2005 + +// PR 19270: ICE +// Origin: Ralf Wildenhues + +template struct Vec { + T* data; + T& operator[](int i) const; +}; + +template inline T& Vec::operator[](int i) const +{ + return (&data[0])[i]; +} + +inline double foo(Vec v) +{ + return v[0]; +}