mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-05 08:00:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Darwin: -Wformat-diag fix (PR93641)

Browse Source 
The length used for the comparison for 'CFStringRef' was only comparing
for 'CFString', potentially allowing mismatched identifiers.

2020-02-10  Iain Sandoe  <iain@sandoe.co.uk>

	PR other/93641
	* config/darwin-c.c (darwin_cfstring_ref_p): Fix up last
	argument of strncmp.
This commit is contained in:
Iain Sandoe 2020-02-10 20:29:30 +01:00
parent 7848054c68
commit c88ffcc6f4
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2020-02-10 Iain Sandoe <iain@sandoe.co.uk>
PR other/93641
* config/darwin-c.c (darwin_cfstring_ref_p): Fix up last
argument of strncmp.
2020-02-10 Hans-Peter Nilsson <hp@axis.com>
Try to generate zero-based comparisons.

3
gcc/config/darwin-c.c
View File

@ -809,7 +809,8 @@ darwin_cfstring_ref_p (const_tree strp)
tn = DECL_NAME (tn);
return (tn
&& IDENTIFIER_POINTER (tn)
&& !strncmp (IDENTIFIER_POINTER (tn), "CFStringRef", 8));
&& !strncmp (IDENTIFIER_POINTER (tn), "CFStringRef",
strlen ("CFStringRef")));
}
/* At present the behavior of this is undefined and it does nothing. */