mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-22 21:31:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

c: After issuing errors about array size, for error-recovery don't make the array VLA [PR93573]

Browse Source 
After we report various errors about array size, we set for error-recovery
the size to be 1, but because size_int_const is false, it still means we
pretend the array is a VLA, can emit a second diagnostics in that case etc.
E.g.
$ ./cc1.unpatched -quiet a.c
a.c:1:5: error: size of array ‘f’ has non-integer type
    1 | int f[100.0];
      |     ^
a.c:1:1: warning: variably modified ‘f’ at file scope
    1 | int f[100.0];
      | ^~~
$ ./cc1 -quiet a.c
a.c:1:5: error: size of array ‘f’ has non-integer type
    1 | int f[100.0];
      |     ^

2020-03-28  Jakub Jelinek  <jakub@redhat.com>

	PR c/93573
	* c-decl.c (grokdeclarator): After issuing errors, set size_int_const
	to true after setting size to integer_one_node.

	* gcc.dg/pr93573-1.c: New test.
	* gcc.dg/pr93573-2.c: New test.
This commit is contained in:
Jakub Jelinek 2020-03-28 10:30:31 +01:00
parent 679becf175
commit c6a562de88
5 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/ChangeLog
View File

@ -1,5 +1,9 @@
2020-03-28 Jakub Jelinek <jakub@redhat.com>
PR c/93573
* c-decl.c (grokdeclarator): After issuing errors, set size_int_const
to true after setting size to integer_one_node.
PR tree-optimization/94329
* tree-ssa-reassoc.c (reassociate_bb): When calling reassoc_remove_stmt
on the last stmt in a bb, make sure gsi_prev isn't done immediately

3
gcc/c/c-decl.c
View File

@ -6416,6 +6416,7 @@ grokdeclarator (const struct c_declarator *declarator,
error_at (loc,
"size of unnamed array has non-integer type");
size = integer_one_node;
size_int_const = true;
}
/* This can happen with enum forward declaration. */
else if (!COMPLETE_TYPE_P (TREE_TYPE (size)))
@ -6427,6 +6428,7 @@ grokdeclarator (const struct c_declarator *declarator,
error_at (loc, "size of unnamed array has incomplete "
"type");
size = integer_one_node;
size_int_const = true;
}
size = c_fully_fold (size, false, &size_maybe_const);
@ -6451,6 +6453,7 @@ grokdeclarator (const struct c_declarator *declarator,
else
error_at (loc, "size of unnamed array is negative");
size = integer_one_node;
size_int_const = true;
}
/* Handle a size folded to an integer constant but
not an integer constant expression. */

4
gcc/testsuite/ChangeLog
View File

@ -1,5 +1,9 @@
2020-03-28 Jakub Jelinek <jakub@redhat.com>
PR c/93573
* gcc.dg/pr93573-1.c: New test.
* gcc.dg/pr93573-2.c: New test.
PR tree-optimization/94329
* gfortran.dg/pr94329.f90: New test.

12
gcc/testsuite/gcc.dg/pr93573-1.c Normal file
View File

@ -0,0 +1,12 @@
/* PR c/93573 */
/* { dg-do compile } */
/* { dg-options "" } */
void bar ();
void
foo (char a)
{
union C { int d[100.0]; char *e; }; /* { dg-error "has non-integer type" } */
bar ((union C) &a);
}

6
gcc/testsuite/gcc.dg/pr93573-2.c Normal file
View File

@ -0,0 +1,6 @@
/* PR c/93573 */
/* { dg-do compile } */
/* { dg-options "" } */
int f[100.0]; /* { dg-error "has non-integer type" } */
/* { dg-bogus "variably modified .f. at file scope" "" { target *-*-* } .-1 } */