Do not generate a unique fnname for resolver.

PR target/93274
	* config/i386/i386-features.c (make_resolver_func):
	Align the code with ppc64 target implementation.
	Do not generate a unique name for resolver function.
	PR target/93274
	* gcc.target/i386/pr81213.c: Adjust to not expect
	a globally unique name.
This commit is contained in:
Martin Liska 2020-01-27 10:48:18 +01:00
parent 1442bc31da
commit c2bd2b4664
No known key found for this signature in database
GPG Key ID: 4DC182DC0FA73785
4 changed files with 19 additions and 17 deletions

View File

@ -1,3 +1,10 @@
2020-01-27 Martin Liska <mliska@suse.cz>
PR target/93274
* config/i386/i386-features.c (make_resolver_func):
Align the code with ppc64 target implementation.
Do not generate a unique name for resolver function.
2020-01-27 Richard Biener <rguenther@suse.de>
PR tree-optimization/93397

View File

@ -2738,26 +2738,16 @@ make_resolver_func (const tree default_decl,
const tree ifunc_alias_decl,
basic_block *empty_bb)
{
char *resolver_name;
tree decl, type, decl_name, t;
tree decl, type, t;
/* IFUNC's have to be globally visible. So, if the default_decl is
not, then the name of the IFUNC should be made unique. */
if (TREE_PUBLIC (default_decl) == 0)
{
char *ifunc_name = make_unique_name (default_decl, "ifunc", true);
symtab->change_decl_assembler_name (ifunc_alias_decl,
get_identifier (ifunc_name));
XDELETEVEC (ifunc_name);
}
resolver_name = make_unique_name (default_decl, "resolver", false);
/* Create resolver function name based on default_decl. */
tree decl_name = clone_function_name (default_decl, "resolver");
const char *resolver_name = IDENTIFIER_POINTER (decl_name);
/* The resolver function should return a (void *). */
type = build_function_type_list (ptr_type_node, NULL_TREE);
decl = build_fn_decl (resolver_name, type);
decl_name = get_identifier (resolver_name);
SET_DECL_ASSEMBLER_NAME (decl, decl_name);
DECL_NAME (decl) = decl_name;
@ -2809,7 +2799,6 @@ make_resolver_func (const tree default_decl,
/* Create the alias for dispatch to resolver here. */
cgraph_node::create_same_body_alias (ifunc_alias_decl, decl);
XDELETEVEC (resolver_name);
return decl;
}

View File

@ -1,3 +1,9 @@
2020-01-27 Martin Liska <mliska@suse.cz>
PR target/93274
* gcc.target/i386/pr81213.c: Adjust to not expect
a globally unique name.
2020-01-27 Richard Biener <rguenther@suse.de>
PR tree-optimization/93397

View File

@ -14,6 +14,6 @@ int main()
return foo();
}
/* { dg-final { scan-assembler "\t.globl\tfoo\\..*\\.ifunc" } } */
/* { dg-final { scan-assembler "\t.globl\tfoo" } } */
/* { dg-final { scan-assembler "foo.resolver:" } } */
/* { dg-final { scan-assembler "foo\\..*\\.ifunc, @gnu_indirect_function" } } */
/* { dg-final { scan-assembler "foo\\, @gnu_indirect_function" } } */