From c132770ebfe92cfab34a79811022437dae051c3b Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 28 Jan 2016 09:39:05 +0100 Subject: [PATCH] re PR pch/68758 (Invalid read of size 8 in gt_pch_save (ggc-common.c:551)) Fix PR pch/68758. PR pch/68758 * ggc-common.c (gt_pch_save): Use ENABLE_VALGRIND_ANNOTATIONS macro instead of ENABLE_VALGRIND_CHECKING. From-SVN: r232915 --- gcc/ChangeLog | 6 ++++++ gcc/ggc-common.c | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 41075467555d..c1d8fafcdb0c 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-01-28 Martin Liska + + PR pch/68758 + * ggc-common.c (gt_pch_save): Use ENABLE_VALGRIND_ANNOTATIONS macro + instead of ENABLE_VALGRIND_CHECKING. + 2016-01-27 Richard Henderson PR rtl-opt/69447 diff --git a/gcc/ggc-common.c b/gcc/ggc-common.c index c919ba8e2eb3..9b291aa33876 100644 --- a/gcc/ggc-common.c +++ b/gcc/ggc-common.c @@ -492,7 +492,7 @@ gt_pch_save (FILE *f) ggc_pch_prepare_write (state.d, state.f); -#if defined ENABLE_VALGRIND_CHECKING && defined VALGRIND_GET_VBITS +#if defined ENABLE_VALGRIND_ANNOTATIONS && defined VALGRIND_GET_VBITS vec vbits = vNULL; #endif @@ -504,7 +504,7 @@ gt_pch_save (FILE *f) this_object_size = state.ptrs[i]->size; this_object = XRESIZEVAR (char, this_object, this_object_size); } -#if defined ENABLE_VALGRIND_CHECKING && defined VALGRIND_GET_VBITS +#if defined ENABLE_VALGRIND_ANNOTATIONS && defined VALGRIND_GET_VBITS /* obj might contain uninitialized bytes, e.g. in the trailing padding of the object. Avoid warnings by making the memory temporarily defined and then restoring previous state. */ @@ -561,7 +561,7 @@ gt_pch_save (FILE *f) state.ptrs[i]->note_ptr_fn == gt_pch_p_S); if (state.ptrs[i]->note_ptr_fn != gt_pch_p_S) memcpy (state.ptrs[i]->obj, this_object, state.ptrs[i]->size); -#if defined ENABLE_VALGRIND_CHECKING && defined VALGRIND_GET_VBITS +#if defined ENABLE_VALGRIND_ANNOTATIONS && defined VALGRIND_GET_VBITS if (__builtin_expect (get_vbits == 1, 0)) { (void) VALGRIND_SET_VBITS (state.ptrs[i]->obj, vbits.address (), @@ -575,7 +575,7 @@ gt_pch_save (FILE *f) } #endif } -#if defined ENABLE_VALGRIND_CHECKING && defined VALGRIND_GET_VBITS +#if defined ENABLE_VALGRIND_ANNOTATIONS && defined VALGRIND_GET_VBITS vbits.release (); #endif