mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-19 08:30:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR go/60870 (go interface methods broken on ppc64le (bug296.go))

Browse Source 
PR go/60870

compiler: Don't convert function type for an interface method.

For an interface method the function type is the type without
the receiver, which is wrong since we are passing a receiver.
The interface method will always have the correct type in this
case, so no type conversion is necessary.

Also don't do the type conversion when calling a named
function, since in that case the type is also always correct.

The type can be wrong, and the conversion required, when the
function type refers to itself recursively.

From-SVN: r209494
This commit is contained in:
Ian Lance Taylor 2014-04-17 19:27:22 +00:00
parent 39be2171e0
commit be7341a882
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gcc/go/gofrontend/expressions.cc
View File

@ -9619,9 +9619,20 @@ Call_expression::do_get_tree(Translate_context* context)
fn = Expression::make_compound(set_closure, fn, location);
}
Btype* bft = fntype->get_backend_fntype(gogo);
Bexpression* bfn = tree_to_expr(fn->get_tree(context));
bfn = gogo->backend()->convert_expression(bft, bfn, location);
// When not calling a named function directly, use a type conversion
// in case the type of the function is a recursive type which refers
// to itself. We don't do this for an interface method because 1)
// an interface method never refers to itself, so we always have a
// function type here; 2) we pass an extra first argument to an
// interface method, so fntype is not correct.
if (func == NULL && !is_interface_method)
{
Btype* bft = fntype->get_backend_fntype(gogo);
bfn = gogo->backend()->convert_expression(bft, bfn, location);
}
Bexpression* call = gogo->backend()->call_expression(bfn, fn_args, location);
if (this->results_ != NULL)