mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-04 23:01:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR fortran/33917 (Rejects valid PROCEDURE declarations)

Browse Source 
2007-11-15  Tobias Burnus  <burnus@net-b.de>

        PR fortran/33917
        * decl.c (match_procedure_decl): Pre-resolve interface.
        * resolve.c (resolve_symbol): Reject interfaces later
        declared in procedure statements.

2007-11-15  Tobias Burnus  <burnus@net-b.de>

        PR fortran/33917
        * gfortran.dg/proc_decl_11.f90: New.

From-SVN: r130202
This commit is contained in:
Tobias Burnus 2007-11-15 16:12:03 +01:00 committed by Tobias Burnus
parent ea6684648c
commit bb343a6c9b
5 changed files with 56 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/fortran/ChangeLog
View File

@ -1,3 +1,10 @@
2007-11-15 Tobias Burnus <burnus@net-b.de>
PR fortran/33917
* decl.c (match_procedure_decl): Pre-resolve interface.
* resolve.c (resolve_symbol): Reject interfaces later
declared in procedure statements.
2007-11-13 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/33162

6
gcc/fortran/decl.c
View File

@ -3946,6 +3946,12 @@ match_procedure_decl (void)
/* Various interface checks. */
if (proc_if)
{
/* Resolve interface if possible. That way, attr.procedure is only set
if it is declared by a later procedure-declaration-stmt, which is
invalid per C1212. */
while (proc_if->interface)
proc_if = proc_if->interface;
if (proc_if->generic)
{
gfc_error ("Interface '%s' at %C may not be generic", proc_if->name);

6
gcc/fortran/resolve.c
View File

@ -7615,8 +7615,10 @@ resolve_symbol (gfc_symbol *sym)
if (sym->attr.procedure && sym->interface
&& sym->attr.if_source != IFSRC_DECL)
{
while (sym->interface->interface)
sym->interface = sym->interface->interface;
if (sym->interface->attr.procedure)
gfc_error ("Interface '%s', used by procedure '%s' at %L, is declared "
"in a later PROCEDURE statement", sym->interface->name,
sym->name,&sym->declared_at);
/* Get the attributes from the interface (now resolved). */
if (sym->interface->attr.if_source || sym->interface->attr.intrinsic)

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2007-11-15 Tobias Burnus <burnus@net-b.de>
PR fortran/33917
* gfortran.dg/proc_decl_11.f90: New.
2007-11-15 Ben Elliston <bje@au.ibm.com>
* gcc.target/spu/compare-dp.c: New test.

34
gcc/testsuite/gfortran.dg/proc_decl_11.f90 Normal file
View File

@ -0,0 +1,34 @@
! { dg-do compile }
! PR fortran/33917
!
! Depending, in which order the symbol tree
! was walked in resolve, gfortran resolved
! p6 before p4; thus there was no explicit
! interface available for p4 and an error
! was printed. (This is a variant of proc_decl_2.f90)
!
! Additionally, the following contrain was not honoured:
! "C1212 (R1215) [...] If name is declared by a procedure-declaration-stmt
! it shall be previously declared." ("name" = interface-name)
!
program s
implicit none
procedure() :: q2
procedure() :: q3
procedure() :: q5
procedure(sub) :: p4
procedure(p4) :: p6
contains
subroutine sub
end subroutine
end program s
subroutine test
implicit none
abstract interface
subroutine sub()
end subroutine sub
end interface
procedure(p4) :: p6 ! { dg-error "declared in a later PROCEDURE statement" }
procedure(sub) :: p4
end subroutine test