mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-24 16:30:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

cprop.c: Adjust outdated comments throughout.

Browse Source 
* cprop.c: Adjust outdated comments throughout.
	(hash_scan_set): Rename PAT parameter into SET.
	(cprop_pavloc): Rename into...
	(cprop_avloc): ...this.
	(cprop_absaltered): Rename into...
	(cprop_kill): ...this.
	(alloc_cprop_mem): Adjust for above renaming.
	(free_cprop_mem): Likewise.
	(compute_cprop_data): Likewise.
	(compute_local_properties): Rename TRANSP parameter into KILL and
	adjust throughout.  Rework comments.
	(try_replace_reg): Fix long line.
	(cprop_jump): Likewise.
	(constprop_register): Fix prototype and take INSN last.
	(cprop_insn): Adjust calls to above function.  Fix long lines.
	(bypass_block): Likewise.
	(one_cprop_pass): Likewise.

From-SVN: r181289
This commit is contained in:
Eric Botcazou 2011-11-11 16:34:16 +00:00
parent ee66e604c3
commit ba5c3b2448
2 changed files with 100 additions and 74 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
gcc/ChangeLog
View File

@ -1,3 +1,23 @@
2011-11-11 Eric Botcazou <ebotcazou@adacore.com>
* cprop.c: Adjust outdated comments throughout.
(hash_scan_set): Rename PAT parameter into SET.
(cprop_pavloc): Rename into...
(cprop_avloc): ...this.
(cprop_absaltered): Rename into...
(cprop_kill): ...this.
(alloc_cprop_mem): Adjust for above renaming.
(free_cprop_mem): Likewise.
(compute_cprop_data): Likewise.
(compute_local_properties): Rename TRANSP parameter into KILL and
adjust throughout. Rework comments.
(try_replace_reg): Fix long line.
(cprop_jump): Likewise.
(constprop_register): Fix prototype and take INSN last.
(cprop_insn): Adjust calls to above function. Fix long lines.
(bypass_block): Likewise.
(one_cprop_pass): Likewise.
2011-11-11 Uros Bizjak <ubizjak@gmail.com>
* config/alpha/elf.h (ELF_ASCII_ESCAPES): Rename from ESCAPES.
@ -23,6 +43,18 @@
Revert
2011-11-05 David S. Miller <davem@davemloft.net>
* config/sparc/sparc.md (UNSPEC_SHORT_LOAD): New unspec.
(zero-extend_v8qi_vis, zero_extend_v4hi_vis): New expanders.
(*zero_extend_v8qi_<P:mode>_insn,
*zero_extend_v4hi_<P:mode>_insn): New insns.
* config/sparc/sparc.c (vector_init_move_words,
vector_init_prepare_elts, sparc_expand_vector_init_vis2,
sparc_expand_vector_init_vis1): New functions.
(vector_init_bshuffle): Rewrite to handle more cases and make use
of locs[] array prepared by vector_init_prepare_elts.
(vector_init_fpmerge, vector_init_faligndata): Delete.
(sparc_expand_vector_init): Rewrite using new infrastructure.
2011-11-11 Jakub Jelinek <jakub@redhat.com>
* opts-common.c (generate_canonical_option): Free opt_text

142
gcc/cprop.c
View File

@ -69,7 +69,7 @@ typedef struct occr *occr_t;
DEF_VEC_P (occr_t);
DEF_VEC_ALLOC_P (occr_t, heap);
/* Hash table entry for an assignment expressions. */
/* Hash table entry for assignment expressions. */
struct expr
{
@ -83,8 +83,8 @@ struct expr
struct expr *next_same_hash;
/* List of available occurrence in basic blocks in the function.
An "available occurrence" is one that is the last occurrence in the
basic block and the operands are not modified by following statements in
the basic block [including this insn]. */
basic block and whose operands are not modified by following statements
in the basic block [including this insn]. */
struct occr *avail_occr;
};
@ -136,7 +136,6 @@ static int local_copy_prop_count;
static int global_const_prop_count;
/* Number of global copies propagated. */
static int global_copy_prop_count;
#define GOBNEW(T) ((T *) cprop_alloc (sizeof (T)))
#define GOBNEWVAR(T, S) ((T *) cprop_alloc ((S)))
@ -256,14 +255,13 @@ cprop_constant_p (const_rtx x)
return CONSTANT_P (x) && (GET_CODE (x) != CONST || shared_const_p (x));
}
/* Scan pattern PAT of INSN and add an entry to the hash TABLE (set or
expression one). */
/* Scan SET present in INSN and add an entry to the hash TABLE. */
static void
hash_scan_set (rtx pat, rtx insn, struct hash_table_d *table)
hash_scan_set (rtx set, rtx insn, struct hash_table_d *table)
{
rtx src = SET_SRC (pat);
rtx dest = SET_DEST (pat);
rtx src = SET_SRC (set);
rtx dest = SET_DEST (set);
if (REG_P (dest)
&& ! HARD_REGISTER_P (dest)
@ -288,7 +286,7 @@ hash_scan_set (rtx pat, rtx insn, struct hash_table_d *table)
&& REG_NOTE_KIND (note) == REG_EQUAL
&& !REG_P (src)
&& cprop_constant_p (XEXP (note, 0)))
src = XEXP (note, 0), pat = gen_rtx_SET (VOIDmode, dest, src);
src = XEXP (note, 0), set = gen_rtx_SET (VOIDmode, dest, src);
/* Record sets for constant/copy propagation. */
if ((REG_P (src)
@ -300,16 +298,7 @@ hash_scan_set (rtx pat, rtx insn, struct hash_table_d *table)
}
}
/* Process INSN and add hash table entries as appropriate.
Only available expressions that set a single pseudo-reg are recorded.
Single sets in a PARALLEL could be handled, but it's an extra complication
that isn't dealt with right now. The trick is handling the CLOBBERs that
are also in the PARALLEL. Later.
If SET_P is nonzero, this is for the assignment hash table,
otherwise it is for the expression hash table. */
/* Process INSN and add hash table entries as appropriate. */
static void
hash_scan_insn (rtx insn, struct hash_table_d *table)
@ -332,6 +321,8 @@ hash_scan_insn (rtx insn, struct hash_table_d *table)
}
}
/* Dump the hash table TABLE to file FILE under the name NAME. */
static void
dump_hash_table (FILE *file, const char *name, struct hash_table_d *table)
{
@ -373,6 +364,7 @@ dump_hash_table (FILE *file, const char *name, struct hash_table_d *table)
}
/* Record as unavailable all registers that are DEF operands of INSN. */
static void
make_set_regs_unavailable (rtx insn)
{
@ -383,7 +375,7 @@ make_set_regs_unavailable (rtx insn)
SET_REGNO_REG_SET (reg_set_bitmap, DF_REF_REGNO (*def_rec));
}
/* Top level function to create an assignments hash table.
/* Top level function to create an assignment hash table.
Assignment entries are placed in the hash table if
- they are of the form (set (pseudo-reg) src),
@ -541,13 +533,12 @@ mark_oprs_set (rtx insn)
for (def_rec = DF_INSN_INFO_DEFS (insn_info); *def_rec; def_rec++)
SET_REGNO_REG_SET (reg_set_bitmap, DF_REF_REGNO (*def_rec));
}
/* Compute copy/constant propagation working variables. */
/* Local properties of assignments. */
static sbitmap *cprop_pavloc;
static sbitmap *cprop_absaltered;
static sbitmap *cprop_avloc;
static sbitmap *cprop_kill;
/* Global properties of assignments (computed from the local properties). */
static sbitmap *cprop_avin;
@ -559,8 +550,8 @@ static sbitmap *cprop_avout;
static void
alloc_cprop_mem (int n_blocks, int n_sets)
{
cprop_pavloc = sbitmap_vector_alloc (n_blocks, n_sets);
cprop_absaltered = sbitmap_vector_alloc (n_blocks, n_sets);
cprop_avloc = sbitmap_vector_alloc (n_blocks, n_sets);
cprop_kill = sbitmap_vector_alloc (n_blocks, n_sets);
cprop_avin = sbitmap_vector_alloc (n_blocks, n_sets);
cprop_avout = sbitmap_vector_alloc (n_blocks, n_sets);
@ -571,8 +562,8 @@ alloc_cprop_mem (int n_blocks, int n_sets)
static void
free_cprop_mem (void)
{
sbitmap_vector_free (cprop_pavloc);
sbitmap_vector_free (cprop_absaltered);
sbitmap_vector_free (cprop_avloc);
sbitmap_vector_free (cprop_kill);
sbitmap_vector_free (cprop_avin);
sbitmap_vector_free (cprop_avout);
}
@ -582,23 +573,23 @@ free_cprop_mem (void)
Local properties are those that are defined by the block, irrespective of
other blocks.
An expression is transparent in a block if its operands are not modified
in the block.
An expression is killed in a block if its operands, either DEST or SRC, are
modified in the block.
An expression is computed (locally available) in a block if it is computed
at least once and expression would contain the same value if the
computation was moved to the end of the block.
TRANSP and COMP are destination sbitmaps for recording local properties. */
KILL and COMP are destination sbitmaps for recording local properties. */
static void
compute_local_properties (sbitmap *transp, sbitmap *comp,
compute_local_properties (sbitmap *kill, sbitmap *comp,
struct hash_table_d *table)
{
unsigned int i;
/* Initialize the bitmaps that were passed in. */
sbitmap_vector_zero (transp, last_basic_block);
sbitmap_vector_zero (kill, last_basic_block);
sbitmap_vector_zero (comp, last_basic_block);
for (i = 0; i < table->size; i++)
@ -611,20 +602,21 @@ compute_local_properties (sbitmap *transp, sbitmap *comp,
df_ref def;
struct occr *occr;
/* The expression is transparent in a block if it is not killed,
i.e. DEST and SRC are not set or clobbered in the block.
We start by assuming all are transparent [none are killed],
and then set the bits for those that are. */
/* For each definition of the destination pseudo-reg, the expression
is killed in the block where the definition is. */
for (def = DF_REG_DEF_CHAIN (REGNO (expr->dest));
def; def = DF_REF_NEXT_REG (def))
SET_BIT (transp[DF_REF_BB (def)->index], indx);
SET_BIT (kill[DF_REF_BB (def)->index], indx);
/* If the source is a pseudo-reg, for each definition of the source,
the expression is killed in the block where the definition is. */
if (REG_P (expr->src))
for (def = DF_REG_DEF_CHAIN (REGNO (expr->src));
def; def = DF_REF_NEXT_REG (def))
SET_BIT (transp[DF_REF_BB (def)->index], indx);
SET_BIT (kill[DF_REF_BB (def)->index], indx);
/* The occurrences recorded in avail_occr are exactly those that
we want to set to nonzero in COMP. */
are locally available in the block where they are. */
for (occr = expr->avail_occr; occr != NULL; occr = occr->next)
{
SET_BIT (comp[BLOCK_FOR_INSN (occr->insn)->index], indx);
@ -641,9 +633,8 @@ compute_local_properties (sbitmap *transp, sbitmap *comp,
static void
compute_cprop_data (void)
{
compute_local_properties (cprop_absaltered, cprop_pavloc, &set_hash_table);
compute_available (cprop_pavloc, cprop_absaltered,
cprop_avout, cprop_avin);
compute_local_properties (cprop_kill, cprop_avloc, &set_hash_table);
compute_available (cprop_avloc, cprop_kill, cprop_avout, cprop_avin);
}
/* Copy/constant propagation. */
@ -748,9 +739,9 @@ try_replace_reg (rtx from, rtx to, rtx insn)
simplify_replace_rtx (XEXP (note, 0), from, to));
if (!success && set && reg_mentioned_p (from, SET_SRC (set)))
{
/* If above failed and this is a single set, try to simplify the source of
the set given our substitution. We could perhaps try this for multiple
SETs, but it probably won't buy us anything. */
/* If above failed and this is a single set, try to simplify the source
of the set given our substitution. We could perhaps try this for
multiple SETs, but it probably won't buy us anything. */
src = simplify_replace_rtx (SET_SRC (set), from, to);
if (!rtx_equal_p (src, SET_SRC (set))
@ -770,7 +761,7 @@ try_replace_reg (rtx from, rtx to, rtx insn)
We could perhaps try this for multiple SETs, but it probably
won't buy us anything. */
rtx dest = simplify_replace_rtx (SET_DEST (set), from, to);
if (!rtx_equal_p (dest, SET_DEST (set))
&& validate_change (insn, &SET_DEST (set), dest, 0))
success = 1;
@ -786,7 +777,7 @@ try_replace_reg (rtx from, rtx to, rtx insn)
return success;
}
/* Find a set of REGNOs that are available on entry to INSN's block. Returns
/* Find a set of REGNOs that are available on entry to INSN's block. Return
NULL no such set is found. */
static struct expr *
@ -856,7 +847,7 @@ find_avail_set (int regno, rtx insn)
JUMP_INSNS. JUMP must be a conditional jump. If SETCC is non-NULL
it is the instruction that immediately precedes JUMP, and must be a
single SET of a register. FROM is what we will try to replace,
SRC is the constant we will try to substitute for it. Returns nonzero
SRC is the constant we will try to substitute for it. Return nonzero
if a change was made. */
static int
@ -940,8 +931,8 @@ cprop_jump (basic_block bb, rtx setcc, rtx jump, rtx from, rtx src)
if (dump_file != NULL)
{
fprintf (dump_file,
"GLOBAL CONST-PROP: Replacing reg %d in jump_insn %d with constant ",
REGNO (from), INSN_UID (jump));
"GLOBAL CONST-PROP: Replacing reg %d in jump_insn %d with"
"constant ", REGNO (from), INSN_UID (jump));
print_rtl (dump_file, src);
fprintf (dump_file, "\n");
}
@ -968,8 +959,12 @@ cprop_jump (basic_block bb, rtx setcc, rtx jump, rtx from, rtx src)
return 1;
}
static bool
constprop_register (rtx insn, rtx from, rtx to)
/* Subroutine of cprop_insn that tries to propagate constants. FROM is what
we will try to replace, SRC is the constant we will try to substitute for
it and INSN is the instruction where this will be happening. */
static int
constprop_register (rtx from, rtx src, rtx insn)
{
rtx sset;
@ -981,13 +976,13 @@ constprop_register (rtx insn, rtx from, rtx to)
{
rtx dest = SET_DEST (sset);
if ((REG_P (dest) || CC0_P (dest))
&& cprop_jump (BLOCK_FOR_INSN (insn), insn, NEXT_INSN (insn), from, to))
&& cprop_jump (BLOCK_FOR_INSN (insn), insn, NEXT_INSN (insn),
from, src))
return 1;
}
/* Handle normal insns next. */
if (NONJUMP_INSN_P (insn)
&& try_replace_reg (from, to, insn))
if (NONJUMP_INSN_P (insn) && try_replace_reg (from, src, insn))
return 1;
/* Try to propagate a CONST_INT into a conditional jump.
@ -997,12 +992,12 @@ constprop_register (rtx insn, rtx from, rtx to)
Right now the insn in question must look like
(set (pc) (if_then_else ...)) */
else if (any_condjump_p (insn) && onlyjump_p (insn))
return cprop_jump (BLOCK_FOR_INSN (insn), NULL, insn, from, to);
return cprop_jump (BLOCK_FOR_INSN (insn), NULL, insn, from, src);
return 0;
}
/* Perform constant and copy propagation on INSN.
The result is nonzero if a change was made. */
Return nonzero if a change was made. */
static int
cprop_insn (rtx insn)
@ -1044,14 +1039,16 @@ retry:
/* Constant propagation. */
if (cprop_constant_p (src))
{
if (constprop_register (insn, reg_used, src))
if (constprop_register (reg_used, src, insn))
{
changed_this_round = changed = 1;
global_const_prop_count++;
if (dump_file != NULL)
{
fprintf (dump_file, "GLOBAL CONST-PROP: Replacing reg %d in ", regno);
fprintf (dump_file, "insn %d with constant ", INSN_UID (insn));
fprintf (dump_file,
"GLOBAL CONST-PROP: Replacing reg %d in ", regno);
fprintf (dump_file, "insn %d with constant ",
INSN_UID (insn));
print_rtl (dump_file, src);
fprintf (dump_file, "\n");
}
@ -1069,7 +1066,8 @@ retry:
global_copy_prop_count++;
if (dump_file != NULL)
{
fprintf (dump_file, "GLOBAL COPY-PROP: Replacing reg %d in insn %d",
fprintf (dump_file,
"GLOBAL COPY-PROP: Replacing reg %d in insn %d",
regno, INSN_UID (insn));
fprintf (dump_file, " with reg %d\n", REGNO (src));
}
@ -1175,7 +1173,7 @@ do_local_cprop (rtx x, rtx insn)
|| ! MEM_P (XEXP (note, 0))))
newreg = this_rtx;
}
if (newcnst && constprop_register (insn, x, newcnst))
if (newcnst && constprop_register (x, newcnst, insn))
{
if (dump_file != NULL)
{
@ -1409,7 +1407,7 @@ find_implicit_sets (void)
static int bypass_last_basic_block;
/* Find a set of REGNO to a constant that is available at the end of basic
block BB. Returns NULL if no such set is found. Based heavily upon
block BB. Return NULL if no such set is found. Based heavily upon
find_avail_set. */
static struct expr *
@ -1444,7 +1442,6 @@ find_bypass_set (int regno, int bb)
return result;
}
/* Subroutine of bypass_block that checks whether a pseudo is killed by
any of the instructions inserted on an edge. Jump bypassing places
condition code setters on CFG edges using insert_insn_on_edge. This
@ -1520,8 +1517,8 @@ bypass_block (basic_block bb, rtx setcc, rtx jump)
}
/* The irreducible loops created by redirecting of edges entering the
loop from outside would decrease effectiveness of some of the following
optimizations, so prevent this. */
loop from outside would decrease effectiveness of some of the
following optimizations, so prevent this. */
if (may_be_loop_header
&& !(e->flags & EDGE_DFS_BACK))
{
@ -1559,7 +1556,6 @@ bypass_block (basic_block bb, rtx setcc, rtx jump)
edges of the CFG. We can't bypass an outgoing edge that
has instructions associated with it, as these insns won't
get executed if the incoming edge is redirected. */
if (new_rtx == pc_rtx)
{
edest = FALLTHRU_EDGE (bb);
@ -1579,7 +1575,6 @@ bypass_block (basic_block bb, rtx setcc, rtx jump)
/* Avoid unification of the edge with other edges from original
branch. We would end up emitting the instruction on "both"
edges. */
if (dest && setcc && !CC0_P (SET_DEST (PATTERN (setcc)))
&& find_edge (e->src, dest))
dest = NULL;
@ -1623,7 +1618,7 @@ bypass_block (basic_block bb, rtx setcc, rtx jump)
/* Find basic blocks with more than one predecessor that only contain a
single conditional jump. If the result of the comparison is known at
compile-time from any incoming edge, redirect that edge to the
appropriate target. Returns nonzero if a change was made.
appropriate target. Return nonzero if a change was made.
This function is now mis-named, because we also handle indirect jumps. */
@ -1687,7 +1682,7 @@ bypass_conditional_jumps (void)
return changed;
}
/* Return true if the graph is too expensive to optimize. PASS is the
/* Return true if the graph is too expensive to optimize. PASS is the
optimization about to be performed. */
static bool
@ -1726,7 +1721,6 @@ is_too_expensive (const char *pass)
return false;
}
/* Main function for the CPROP pass. */
@ -1800,7 +1794,8 @@ one_cprop_pass (void)
/* Allocate vars to track sets of regs. */
reg_set_bitmap = ALLOC_REG_SET (NULL);
FOR_BB_BETWEEN (bb, ENTRY_BLOCK_PTR->next_bb->next_bb, EXIT_BLOCK_PTR, next_bb)
FOR_BB_BETWEEN (bb, ENTRY_BLOCK_PTR->next_bb->next_bb, EXIT_BLOCK_PTR,
next_bb)
{
/* Reset tables used to keep track of what's still valid [since
the start of the block]. */
@ -1841,7 +1836,6 @@ one_cprop_pass (void)
return changed;
}
/* All the passes implemented in this file. Each pass has its
own gate and execute function, and at the end of the file a