mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-18 06:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

asan: Fix up error recovery for too large frames [PR107317]

Browse Source 
asan_emit_stack_protection and functions it calls have various asserts that
verify sanity of the stack protection instrumentation.  But, that
verification can easily fail if we've diagnosed a frame offset overflow.
asan_emit_stack_protection just emits some extra code in the prologue,
if we've reported errors, we aren't producing assembly, so it doesn't
really matter if we don't include the protection code, compilation
is going to fail anyway.

2022-11-24  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/107317
	* asan.cc: Include diagnostic-core.h.
	(asan_emit_stack_protection): Return NULL early if seen_error ().

	* gcc.dg/asan/pr107317.c: New test.
This commit is contained in:
Jakub Jelinek 2022-11-24 11:29:54 +01:00
parent 7f77aa6b2f
commit b6330a7685
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/asan.cc
View File

@ -64,6 +64,7 @@ along with GCC; see the file COPYING3. If not see
#include "tree-inline.h"
#include "tree-ssa.h"
#include "tree-eh.h"
#include "diagnostic-core.h"
/* AddressSanitizer finds out-of-bounds and use-after-free bugs
with <2x slowdown on average.
@ -1818,6 +1819,11 @@ asan_emit_stack_protection (rtx base, rtx pbase, unsigned int alignb,
tree str_cst, decl, id;
int use_after_return_class = -1;
/* Don't emit anything when doing error recovery, the assertions
might fail e.g. if a function had a frame offset overflow. */
if (seen_error ())
return NULL;
if (shadow_ptr_types[0] == NULL_TREE)
asan_init_shadow_ptr_types ();

13
gcc/testsuite/gcc.dg/asan/pr107317.c Normal file
View File

@ -0,0 +1,13 @@
/* PR middle-end/107317 */
/* { dg-do compile { target ilp32 } } */
/* { dg-options "-fsanitize=address -ffat-lto-objects" } */
void bar (float *, float *);
void
foo (void) /* { dg-error "exceeds maximum" } */
{
float a[400000000];
float b[200000000];
bar (a, b);
}