mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-05 10:40:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove superfluous assignment in add_params.

Browse Source 
This fixes the superfluous assignment that Coverity reported in add_params,
and changes the starting index from 0 to num_params - n in order for it to
work properly if add_params is called multiple times.

validate_params calls error so it doesn't matter that we don't check the
results here.  The results is checked in individual parameter updates after
front-end initialization.

2018-10-04  Tamar Christina  <tamar.christina@arm.com>

	* params.c (add_params): Fix initialization.

From-SVN: r264841
This commit is contained in:
Tamar Christina 2018-10-04 13:06:59 +00:00 committed by Tamar Christina
parent 3edbcdbead
commit ac712e4eb4
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/ChangeLog
View File

@ -1,3 +1,7 @@
2018-10-04 Tamar Christina <tamar.christina@arm.com>
* params.c (add_params): Fix initialization.
2018-10-04 Martin Liska <mliska@suse.cz>
PR gcov-profile/84107

10
gcc/params.c
View File

@ -87,12 +87,10 @@ add_params (const param_info params[], size_t n)
if (!diagnostic_ready_p ())
diagnostic_initialize (global_dc, 0);
/* Now perform some validation and set the value if it validates. */
for (size_t i = 0; i < n; i++)
{
if (validate_param (dst_params[i].default_value, dst_params[i], (int)i))
dst_params[i].default_value = dst_params[i].default_value;
}
/* Now perform some validation and validation failures trigger an error so
initialization will stop. */
for (size_t i = num_compiler_params - n; i < n; i++)
validate_param (params[i].default_value, params[i], (int)i);
}
/* Add all parameters and default values that can be set in both the