mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-03 05:10:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR c/71514 (ICE on C11 code with atomic exchange at -O1 and above on x86_64-linux-gnu: in copy_reference_ops_from_ref, at tree-ssa-sccvn.c:879)

Browse Source 
PR c/71514
	* c-common.c (get_atomic_generic_size): Disallow pointer-to-function
	and pointer-to-VLA.

	* gcc.dg/pr71514.c: New test.

From-SVN: r239581
This commit is contained in:
Marek Polacek 2016-08-18 16:38:49 +00:00 committed by Marek Polacek
parent f87e22c521
commit a76989dc7c
4 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/c-family/ChangeLog
View File

@ -1,3 +1,9 @@
2016-08-18 Marek Polacek <polacek@redhat.com>
PR c/71514
* c-common.c (get_atomic_generic_size): Disallow pointer-to-function
and pointer-to-VLA.
2016-08-16 David Malcolm <dmalcolm@redhat.com>
PR c/72857

14
gcc/c-family/c-common.c
View File

@ -11081,6 +11081,20 @@ get_atomic_generic_size (location_t loc, tree function,
function);
return 0;
}
else if (TYPE_SIZE_UNIT (TREE_TYPE (type))
&& TREE_CODE ((TYPE_SIZE_UNIT (TREE_TYPE (type))))
!= INTEGER_CST)
{
error_at (loc, "argument %d of %qE must be a pointer to a constant "
"size type", x + 1, function);
return 0;
}
else if (FUNCTION_POINTER_TYPE_P (type))
{
error_at (loc, "argument %d of %qE must not be a pointer to a "
"function", x + 1, function);
return 0;
}
tree type_size = TYPE_SIZE_UNIT (TREE_TYPE (type));
size = type_size ? tree_to_uhwi (type_size) : 0;
if (size != size_0)

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2016-08-18 Marek Polacek <polacek@redhat.com>
PR c/71514
* gcc.dg/pr71514.c: New test.
2015-08-18 H.J. Lu <hongjiu.lu@intel.com>
PR target/72839

23
gcc/testsuite/gcc.dg/pr71514.c Normal file
View File

@ -0,0 +1,23 @@
/* PR c/71514 */
/* { dg-do compile } */
/* { dg-options "" } */
void
foo ()
{
}
int a, b;
void
fn1 (void)
{
__atomic_exchange (&a, &foo, &b, __ATOMIC_RELAXED); /* { dg-error "must not be a pointer to a function" } */
}
void
fn2 (int n)
{
int arr[n];
__atomic_exchange (&a, &arr, &b, __ATOMIC_RELAXED); /* { dg-error "must be a pointer to a constant size type" } */
}