mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-06 19:51:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

sem_util.adb, [...]: Correct false positive warnings.

Browse Source 
2014-01-24  Robert Dewar  <dewar@adacore.com>

	* sem_util.adb, lib-xref.adb: Correct false positive warnings.

From-SVN: r207031
This commit is contained in:
Robert Dewar 2014-01-24 14:03:19 +00:00 committed by Arnaud Charlet
parent 0bd38d942c
commit a6ae518ff7
3 changed files with 29 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/ada/ChangeLog
View File

@ -1,3 +1,7 @@
2014-01-24 Robert Dewar <dewar@adacore.com>
* sem_util.adb, lib-xref.adb: Correct false positive warnings.
2014-01-24 Vincent Celier <celier@adacore.com>
* projects.texi: Document that aggregate projects are only

30
gcc/ada/lib-xref.adb
View File

@ -432,6 +432,7 @@ package body Lib.Xref is
-- ??? There are several routines here and there that perform a similar
-- (but subtly different) computation, which should be factored:
-- Sem_Util.Is_LHS
-- Sem_Util.May_Be_Lvalue
-- Sem_Util.Known_To_Be_Assigned
-- Exp_Ch2.Expand_Entry_Parameter.In_Assignment_Context
@ -473,20 +474,27 @@ package body Lib.Xref is
-- ??? case of a slice assignment?
-- ??? Note that in some cases this is called too early
-- (see comments in Sem_Ch8.Find_Direct_Name), at a point where
-- the tree is not fully typed yet. In that case we may lack
-- an Etype for N, and we must disable the check for an implicit
-- dereference. If the dereference is on an LHS, this causes a
-- false positive.
elsif (K = N_Selected_Component or else K = N_Indexed_Component)
and then Prefix (P) = N
and then not (Present (Etype (N))
and then
Is_Access_Type (Etype (N)))
then
N := P;
-- Check for access type. First a kludge, In some cases this is
-- called too early (see comments in Sem_Ch8.Find_Direct_Name),
-- at a point where the tree is not fully typed yet. In that
-- case we may lack an Etype for N, and we can't check the
-- Etype. For now, we always return False in such a case,
-- but this is clearly not right in all cases ???
if No (Etype (N)) then
return False;
elsif Is_Access_Type (Etype (N)) then
return False;
-- Access type case dealt with, keep going
else
N := P;
end if;
-- All other cases, definitely not on left side

7
gcc/ada/sem_util.adb
View File

@ -9882,7 +9882,12 @@ package body Sem_Util is
-- a reference as a modification. It is not clear if there are any
-- other bad consequences. ???
if Present (Etype (N)) and then Is_Access_Type (Etype (N)) then
if No (Etype (N)) then
return False;
-- We have an Etype set, so we can check it
elsif Is_Access_Type (Etype (N)) then
return False;
-- OK, not access type case, so just test whole expression