mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-06 02:20:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR fortran/33664 (crash on invalid program)

Browse Source 
2007-10-12  Paul Thomas  <pault@gcc.gnu.org>

	PR fortran/33664
	* expr.c (gfc_specification_expr): If a function is not
	external, intrinsic or pure is an error.  Set the symbol pure
	to prevent repeat errors.

2007-10-12  Paul Thomas  <pault@gcc.gnu.org>

	PR fortran/33664
	* gfortran.dg/impure_spec_expr_1.f90: New test.
	* gfortran.dg/char_result_7.f90: Remove illegal test.

From-SVN: r129267
This commit is contained in:
Paul Thomas 2007-10-12 16:45:46 +00:00
parent e69f1bad5d
commit 98a36c7ca0
5 changed files with 40 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/fortran/ChangeLog
View File

@ -1,3 +1,10 @@
2007-10-12 Paul Thomas <pault@gcc.gnu.org>
PR fortran/33664
* expr.c (gfc_specification_expr): If a function is not
external, intrinsic or pure is an error. Set the symbol pure
to prevent repeat errors.
2007-10-10 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR fortran/33636

12
gcc/fortran/expr.c
View File

@ -2526,6 +2526,18 @@ gfc_specification_expr (gfc_expr *e)
return FAILURE;
}
if (e->expr_type == EXPR_FUNCTION
&& !e->value.function.isym
&& !e->value.function.esym
&& !gfc_pure (e->symtree->n.sym))
{
gfc_error ("Function '%s' at %L must be PURE",
e->symtree->n.sym->name, &e->where);
/* Prevent repeat error messages. */
e->symtree->n.sym->attr.pure = 1;
return FAILURE;
}
if (e->rank != 0)
{
gfc_error ("Expression at %L must be scalar", &e->where);

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2007-10-12 Paul Thomas <pault@gcc.gnu.org>
PR fortran/33664
* gfortran.dg/impure_spec_expr_1.f90: New test.
* gfortran.dg/char_result_7.f90: Remove illegal test.
2007-10-12 Nathan Froyd <froydnj@codesourcery.com>
PR 11001

8
gcc/testsuite/gfortran.dg/char_result_7.f90
View File

@ -16,7 +16,6 @@ program main
end interface
call test (f1 (double, 100), 200)
call test (f2 (double, 70), 140)
call indirect (double)
contains
@ -31,12 +30,6 @@ contains
f1 = ''
end function f1
function f2 (fn, i)
integer :: i, fn
character (len = fn (i)) :: f2
f2 = ''
end function f2
subroutine indirect (fn)
interface
integer pure function fn (x)
@ -44,7 +37,6 @@ contains
end function fn
end interface
call test (f1 (fn, 100), 200)
call test (f2 (fn, 70), 140)
end subroutine indirect
subroutine test (string, length)

15
gcc/testsuite/gfortran.dg/impure_spec_expr_1.f90 Normal file
View File

@ -0,0 +1,15 @@
! { dg-do compile }
! Checks the fix for PR33664, in which the apparent function reference
! n(1) caused a seg-fault.
!
! Contributed by Henrik Holst <holst@matmech.com>
!
module test
contains
subroutine func_1(u,n)
integer :: n
integer :: u(n(1)) ! { dg-error "must be PURE" }
end subroutine
end module test
! { dg-final { cleanup-modules "test" } }