mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-02-27 02:15:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

libgcc: Fix backtrace fallback on PowerPC Big-endian

Browse Source 
At the end of the backtrace stream _Unwind_Find_FDE() may not be able
to find the frame unwind info and will later call the backtrace fallback
instead of finishing. This occurs when using an old libc on ppc64 due to
dl_iterate_phdr() not being able to set the fde in the last trace.
When this occurs the cfa of the trace will be behind of context's cfa.
Also, libgo’s probestackmaps() calls the backtrace with a null pointer
and can get to the backchain fallback with the same problem, in this case
we are only interested in find a stack map, we don't need nor can do a
backchain.
_Unwind_ForcedUnwind_Phase2() can hit the same issue as it uses
uw_frame_state_for(), so we need to treat _URC_NORMAL_STOP.

libgcc/ChangeLog:
	PR libgcc/103044
	* config/rs6000/linux-unwind.h (ppc_backchain_fallback): Check if it's
	called with a null argument or at the end of the backtrace and return.
	* unwind.inc (_Unwind_ForcedUnwind_Phase2): Treat _URC_NORMAL_STOP.
This commit is contained in:
Raphael Moreira Zinsly 2021-11-11 11:40:10 -03:00 committed by Segher Boessenkool
parent 8d3abf42d5
commit 8d71d3a317
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libgcc/config/rs6000/linux-unwind.h
View File

@ -402,8 +402,14 @@ ppc_backchain_fallback (struct _Unwind_Context *context, void *a)
struct trace_arg *arg = a;
int count;
/* Get the last address computed and start with the next. */
/* Get the last address computed. */
current = context->cfa;
/* If the trace CFA is not the context CFA the backtrace is done. */
if (arg == NULL || arg->cfa != current)
return;
/* Start with next address. */
current = current->backchain;
for (count = arg->count; current != NULL; current = current->backchain)

5
libgcc/unwind.inc
View File

@ -160,12 +160,13 @@ _Unwind_ForcedUnwind_Phase2 (struct _Unwind_Exception *exc,
/* Set up fs to describe the FDE for the caller of cur_context. */
code = uw_frame_state_for (context, &fs);
if (code != _URC_NO_REASON && code != _URC_END_OF_STACK)
if (code != _URC_NO_REASON && code != _URC_END_OF_STACK
&& code != _URC_NORMAL_STOP)
return _URC_FATAL_PHASE2_ERROR;
/* Unwind successful. */
action = _UA_FORCE_UNWIND | _UA_CLEANUP_PHASE;
if (code == _URC_END_OF_STACK)
if (code == _URC_END_OF_STACK || code == _URC_NORMAL_STOP)
action |= _UA_END_OF_STACK;
stop_code = (*stop) (1, action, exc->exception_class, exc,
context, stop_argument);