mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-11 06:20:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

forwprop: Fix ICE when building a VEC_PERM_EXPR [PR94683]

Browse Source 
The type compatibility handling in simplify_vector_constructor is
based on the number of elements and on element type compatibility,
but that's no longer enough to ensure that two vector types are
compatible.  This patch uses a VIEW_CONVERT_EXPR if the permutation
type and result type are distinct.

2020-04-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
	PR tree-optimization/94683
	* tree-ssa-forwprop.c (simplify_vector_constructor): Use a
	VIEW_CONVERT_EXPR to handle mixtures of similarly-structured
	but distinct vector types.

gcc/testsuite/
	PR tree-optimization/94683
	* gcc.target/aarch64/sve/acle/general/pr94683.c: New test.
This commit is contained in:
Richard Sandiford 2020-04-21 16:11:07 +01:00
parent 619602346a
commit 85353e24ca
4 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/ChangeLog
View File

@ -1,3 +1,10 @@
2020-04-21 Richard Sandiford <richard.sandiford@arm.com>
PR tree-optimization/94683
* tree-ssa-forwprop.c (simplify_vector_constructor): Use a
VIEW_CONVERT_EXPR to handle mixtures of similarly-structured
but distinct vector types.
2020-04-21 Jakub Jelinek <jakub@redhat.com>
PR c/94641

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-04-21 Richard Sandiford <richard.sandiford@arm.com>
PR tree-optimization/94683
* gcc.target/aarch64/sve/acle/general/pr94683.c: New test.
2020-04-21 Jakub Jelinek <jakub@redhat.com>
PR c++/94383

29
gcc/testsuite/gcc.target/aarch64/sve/acle/general/pr94683.c Normal file
View File

@ -0,0 +1,29 @@
/* { dg-options "-O2 -msve-vector-bits=256" } */
/* { dg-final { check-function-bodies "**" "" } } */
#include <arm_sve.h>
typedef float v8sf __attribute__((vector_size(32)));
#ifdef __cplusplus
extern "C" {
#endif
/*
** test:
** fadd z0\.s, p0/m, z0\.s, #1.0
** trn1 z0\.s, z0\.s, z0\.s
** fdiv z0\.s, p0/m, z0\.s, z1\.s
** ret
*/
svfloat32_t
test (svbool_t pg, svfloat32_t x, svfloat32_t y)
{
v8sf a = svadd_x (pg, x, 1);
v8sf b = { a[0], a[0], a[2], a[2], a[4], a[4], a[6], a[6] };
return svdiv_x (pg, b, y);
}
#ifdef __cplusplus
}
#endif

5
gcc/tree-ssa-forwprop.c
View File

@ -2598,6 +2598,11 @@ simplify_vector_constructor (gimple_stmt_iterator *gsi)
res, TYPE_SIZE (type), bitsize_zero_node);
if (conv_code != ERROR_MARK)
res = gimple_build (&stmts, conv_code, type, res);
else if (!useless_type_conversion_p (type, TREE_TYPE (res)))
{
gcc_assert (!targetm.compatible_vector_types_p (type, perm_type));
res = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, res);
}
/* Blend in the actual constant. */
if (converted_orig1)
res = gimple_build (&stmts, VEC_PERM_EXPR, type,