mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-01-10 16:55:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

[PR107608] [range-ops] Avoid folding into INF when flag_trapping_math.

Browse Source 
As discussed in the PR, for trapping math, do not fold overflowing
operations into +-INF as doing so could elide a trap.

There is a minor adjustment to known_isinf() where it was mistakenly
returning true for an [infinity U NAN], whereas it should only return
true when the range is exclusively +INF or -INF.  This is benign, as
there were no users of known_isinf up to now.

Tested on x86-64 Linux.

I also ran the glibc testsuite (git sources) on x86-64 and this patch
fixes:

-FAIL: math/test-double-lgamma
-FAIL: math/test-double-log1p
-FAIL: math/test-float-lgamma
-FAIL: math/test-float-log1p
-FAIL: math/test-float128-catan
-FAIL: math/test-float128-catanh
-FAIL: math/test-float128-lgamma
-FAIL: math/test-float128-log
-FAIL: math/test-float128-log1p
-FAIL: math/test-float128-y0
-FAIL: math/test-float128-y1
-FAIL: math/test-float32-lgamma
-FAIL: math/test-float32-log1p
-FAIL: math/test-float32x-lgamma
-FAIL: math/test-float32x-log1p
-FAIL: math/test-float64-lgamma
-FAIL: math/test-float64-log1p
-FAIL: math/test-float64x-lgamma
-FAIL: math/test-ldouble-lgamma

	PR tree-optimization/107608

gcc/ChangeLog:

	* range-op-float.cc (range_operator_float::fold_range): Avoid
	folding into INF when flag_trapping_math.
	* value-range.h (frange::known_isinf): Return false for possible NANs.
This commit is contained in:
Aldy Hernandez 2023-01-10 10:57:16 +01:00
parent 5ba715ed1a
commit 844190af17
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
gcc/range-op-float.cc
View File

@ -91,6 +91,27 @@ range_operator_float::fold_range (frange &r, tree type,
else
r.clear_nan ();
// If the result has overflowed and flag_trapping_math, folding this
// operation could elide an overflow or division by zero exception.
// Avoid returning a singleton +-INF, to keep the propagators (DOM
// and substitute_and_fold_engine) from folding. See PR107608.
if (flag_trapping_math
&& MODE_HAS_INFINITIES (TYPE_MODE (type))
&& r.known_isinf () && !op1.known_isinf () && !op2.known_isinf ())
{
REAL_VALUE_TYPE inf = r.lower_bound ();
if (real_isneg (&inf))
{
REAL_VALUE_TYPE min = real_min_representable (type);
r.set (type, inf, min);
}
else
{
REAL_VALUE_TYPE max = real_max_representable (type);
r.set (type, max, inf);
}
}
return true;
}

1
gcc/value-range.h
View File

@ -1300,6 +1300,7 @@ inline bool
frange::known_isinf () const
{
return (m_kind == VR_RANGE
&& !maybe_isnan ()
&& real_identical (&m_min, &m_max)
&& real_isinf (&m_min));
}