mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-19 18:20:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

c++: Redundant -Wdeprecated-declarations warning in build_over_call [PR67960]

Browse Source 
In build_over_call, we are emitting a redundant -Wdeprecated-declarations
warning about the deprecated callee function, first from mark_used and again
from build_addr_func <- decay_conversion <- cp_build_addr_expr <- mark_used.

It seems this second deprecation warning coming from build_addr_func will always
be redundant, so we can safely use a warning_sentinel to disable it before
calling build_addr_func.  (And any deprecation warning that could come from
build_addr_func would be for FN, so we wouldn't be suppressing too much.)

gcc/cp/ChangeLog:

	PR c++/67960
	* call.c (build_over_call): Use a warning_sentinel to disable
	warn_deprecated_decl before calling build_addr_func.

gcc/testsuite/ChangeLog:

	PR c++/67960
	* g++.dg/diagnostic/pr67960.C: New test.
	* g++.dg/diagnostic/pr67960-2.C: New test.
This commit is contained in:
Patrick Palka 2020-03-12 14:38:42 -04:00
parent 3604480a6f
commit 80a13af724
5 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2020-03-13 Patrick Palka <ppalka@redhat.com>
PR c++/67960
* call.c (build_over_call): Use a warning_sentinel to disable
warn_deprecated_decl before calling build_addr_func.
2020-03-12 Jakub Jelinek <jakub@redhat.com>
PR c++/94124

5
gcc/cp/call.c
View File

@ -9062,6 +9062,11 @@ build_over_call (struct z_candidate *cand, int flags, tsubst_flags_t complain)
}
else
{
/* If FN is marked deprecated, then we've already issued a deprecated-use
warning from mark_used above, so avoid redundantly issuing another one
from build_addr_func. */
warning_sentinel w (warn_deprecated_decl);
fn = build_addr_func (fn, complain);
if (fn == error_mark_node)
return error_mark_node;

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2020-03-13 Patrick Palka <ppalka@redhat.com>
PR c++/67960
* g++.dg/diagnostic/pr67960.C: New test.
* g++.dg/diagnostic/pr67960-2.C: New test.
2020-03-13 Martin Liska <mliska@suse.cz>
PR lto/94157

13
gcc/testsuite/g++.dg/diagnostic/pr67960-2.C Normal file
View File

@ -0,0 +1,13 @@
// PR c++/67960
// { dg-do compile }
// { dg-additional-options "-Werror -fmax-errors=1" }
__attribute__((deprecated)) void doNothing(){}
int
main()
{
doNothing(); // { dg-error "is deprecated" }
}
// { dg-message "all warnings being treated as errors" "" { target *-*-* } 0 }
// { dg-bogus "compilation terminated" "" { target *-*-* } 0 }

13
gcc/testsuite/g++.dg/diagnostic/pr67960.C Normal file
View File

@ -0,0 +1,13 @@
// PR c++/67960
// { dg-do compile { target c++14 } }
// { dg-additional-options "-Werror -fmax-errors=1" }
[[deprecated]] void doNothing(){}
int
main()
{
doNothing(); // { dg-error "is deprecated" }
}
// { dg-message "all warnings being treated as errors" "" { target *-*-* } 0 }
// { dg-bogus "compilation terminated" "" { target *-*-* } 0 }