mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-19 03:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR middle-end/48973 (Inliner bug with one-bit (1-bit) bitfield)

Browse Source 
PR middle-end/48973
	* expr.c (expand_expr_real_2) <case LT_EXPR>: If do_store_flag
	failed and the comparison has a single bit signed type, use
	constm1_rtx instead of const1_rtx for true value.
	(do_store_flag): If ops->type is single bit signed type, disable
	signel bit test optimization and pass -1 instead of 1 as last
	parameter to emit_store_flag_force.

	* gcc.c-torture/execute/pr48973-1.c: New test.
	* gcc.c-torture/execute/pr48973-2.c: New test.

From-SVN: r174060
This commit is contained in:
Jakub Jelinek 2011-05-23 11:36:05 +02:00 committed by Jakub Jelinek
parent c11e39b0bd
commit 7bba408b97
5 changed files with 59 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gcc/ChangeLog
View File

@ -1,3 +1,13 @@
2011-05-23 Jakub Jelinek <jakub@redhat.com>
PR middle-end/48973
* expr.c (expand_expr_real_2) <case LT_EXPR>: If do_store_flag
failed and the comparison has a single bit signed type, use
constm1_rtx instead of const1_rtx for true value.
(do_store_flag): If ops->type is single bit signed type, disable
signel bit test optimization and pass -1 instead of 1 as last
parameter to emit_store_flag_force.
2011-05-23 Tom de Vries <tom@codesourcery.com>
PR target/45098

12
gcc/expr.c
View File

@ -8105,7 +8105,10 @@ expand_expr_real_2 (sepops ops, rtx target, enum machine_mode tmode,
op1 = gen_label_rtx ();
jumpifnot_1 (code, treeop0, treeop1, op1, -1);
emit_move_insn (target, const1_rtx);
if (TYPE_PRECISION (type) == 1 && !TYPE_UNSIGNED (type))
emit_move_insn (target, constm1_rtx);
else
emit_move_insn (target, const1_rtx);
emit_label (op1);
return target;
@ -10050,7 +10053,8 @@ do_store_flag (sepops ops, rtx target, enum machine_mode mode)
if ((code == NE || code == EQ)
&& TREE_CODE (arg0) == BIT_AND_EXPR && integer_zerop (arg1)
&& integer_pow2p (TREE_OPERAND (arg0, 1)))
&& integer_pow2p (TREE_OPERAND (arg0, 1))
&& (TYPE_PRECISION (ops->type) != 1 || TYPE_UNSIGNED (ops->type)))
{
tree type = lang_hooks.types.type_for_mode (mode, unsignedp);
return expand_expr (fold_single_bit_test (loc,
@ -10070,7 +10074,9 @@ do_store_flag (sepops ops, rtx target, enum machine_mode mode)
/* Try a cstore if possible. */
return emit_store_flag_force (target, code, op0, op1,
operand_mode, unsignedp, 1);
operand_mode, unsignedp,
(TYPE_PRECISION (ops->type) == 1
&& !TYPE_UNSIGNED (ops->type)) ? -1 : 1);
}

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2011-05-23 Jakub Jelinek <jakub@redhat.com>
PR middle-end/48973
* gcc.c-torture/execute/pr48973-1.c: New test.
* gcc.c-torture/execute/pr48973-2.c: New test.
2011-05-23 Jonathan Wakely <jwakely.gcc@gmail.com>
PR c++/18016

20
gcc/testsuite/gcc.c-torture/execute/pr48973-1.c Normal file
View File

@ -0,0 +1,20 @@
/* PR middle-end/48973 */
extern void abort (void);
struct S { int f : 1; } s;
int v = -1;
void
foo (unsigned int x)
{
if (x != -1U)
abort ();
}
int
main ()
{
s.f = (v & 1) > 0;
foo (s.f);
return 0;
}

14
gcc/testsuite/gcc.c-torture/execute/pr48973-2.c Normal file
View File

@ -0,0 +1,14 @@
/* PR middle-end/48973 */
extern void abort (void);
struct S { int f : 1; } s;
int v = -1;
int
main ()
{
s.f = v < 0;
if ((unsigned int) s.f != -1U)
abort ();
return 0;
}