mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-18 23:31:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR c/64709 (Bogus -Wmissing-field-initializers warning)

Browse Source 
PR c/64709
	* c-typeck.c (pop_init_level): If constructor_elements has
	exactly one element with integer_zerop value, set constructor_zeroinit
	to 1.  Remove braces around warning_init call.

	* gcc.dg/pr64709.c: New test.

From-SVN: r220263
This commit is contained in:
Marek Polacek 2015-01-29 21:02:21 +00:00 committed by Marek Polacek
parent a7c3e87ed9
commit 7b33f0c8e6
4 changed files with 40 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/c/ChangeLog
View File

@ -1,3 +1,10 @@
2015-01-29 Marek Polacek <polacek@redhat.com>
PR c/64709
* c-typeck.c (pop_init_level): If constructor_elements has
exactly one element with integer_zerop value, set constructor_zeroinit
to 1. Remove braces around warning_init call.
2015-01-27 Jakub Jelinek <jakub@redhat.com>
PR c/64766

28
gcc/c/c-typeck.c
View File

@ -7557,20 +7557,28 @@ pop_init_level (location_t loc, int implicit,
}
}
/* Initialization with { } counts as zeroinit. */
if (vec_safe_length (constructor_elements) == 0)
constructor_zeroinit = 1;
/* If the constructor has more than one element, it can't be { 0 }. */
else if (vec_safe_length (constructor_elements) != 1)
constructor_zeroinit = 0;
switch (vec_safe_length (constructor_elements))
{
case 0:
/* Initialization with { } counts as zeroinit. */
constructor_zeroinit = 1;
break;
case 1:
/* This might be zeroinit as well. */
if (integer_zerop ((*constructor_elements)[0].value))
constructor_zeroinit = 1;
break;
default:
/* If the constructor has more than one element, it can't be { 0 }. */
constructor_zeroinit = 0;
break;
}
/* Warn when some structs are initialized with direct aggregation. */
if (!implicit && found_missing_braces && warn_missing_braces
&& !constructor_zeroinit)
{
warning_init (loc, OPT_Wmissing_braces,
"missing braces around initializer");
}
warning_init (loc, OPT_Wmissing_braces,
"missing braces around initializer");
/* Warn when some struct elements are implicitly initialized to zero. */
if (warn_missing_field_initializers

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2015-01-29 Marek Polacek <polacek@redhat.com>
PR c/64709
* gcc.dg/pr64709.c: New test.
2015-01-29 Jakub Jelinek <jakub@redhat.com>
PR c++/64717

10
gcc/testsuite/gcc.dg/pr64709.c Normal file
View File

@ -0,0 +1,10 @@
/* PR c/64709 */
/* { dg-do compile } */
/* { dg-options "-Wmissing-field-initializers" } */
struct S { int a, b; };
void
foo (void)
{
struct S s[] = { { 1, 2 }, { 0 } }; /* { dg-bogus "missing initializer for field" } */
}