mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-19 01:50:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

c++: explicit(bool) malfunction with dependent expression [PR95066]

Browse Source 
I forgot to set DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P when merging two
function declarations and as a sad consequence, we never tsubsted
the dependent explicit-specifier in tsubst_function_decl, leading to
disregarding the explicit-specifier altogether, and wrongly accepting
this test.

	PR c++/95066
	* decl.c (duplicate_decls): Set DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P.

	* g++.dg/cpp2a/explicit16.C: New test.
This commit is contained in:
Marek Polacek 2020-05-11 18:28:19 -04:00
parent 7040894c44
commit 661232da72
4 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/cp/ChangeLog
View File

@ -1,3 +1,8 @@
2020-05-13 Marek Polacek <polacek@redhat.com>
PR c++/95066
* decl.c (duplicate_decls): Set DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P.
2020-05-13 Nathan Sidwell <nathan@acm.org>
* pt.c (template_args_equal): Reorder category checking for

2
gcc/cp/decl.c
View File

@ -2035,6 +2035,8 @@ duplicate_decls (tree newdecl, tree olddecl, bool newdecl_is_friend)
DECL_FINAL_P (newdecl) |= DECL_FINAL_P (olddecl);
DECL_OVERRIDE_P (newdecl) |= DECL_OVERRIDE_P (olddecl);
DECL_THIS_STATIC (newdecl) |= DECL_THIS_STATIC (olddecl);
DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P (newdecl)
|= DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P (olddecl);
if (DECL_OVERLOADED_OPERATOR_P (olddecl))
DECL_OVERLOADED_OPERATOR_CODE_RAW (newdecl)
= DECL_OVERLOADED_OPERATOR_CODE_RAW (olddecl);

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-05-13 Marek Polacek <polacek@redhat.com>
PR c++/95066
* g++.dg/cpp2a/explicit16.C: New test.
2020-05-13 Jason Merrill <jason@redhat.com>
* lib/target-supports.exp (check_effective_target_c++20_only)

21
gcc/testsuite/g++.dg/cpp2a/explicit16.C Normal file
View File

@ -0,0 +1,21 @@
// PR c++/95066 - explicit malfunction with dependent expression.
// { dg-do compile { target c++2a } }
template <typename T>
struct Foo {
template <typename U>
explicit(static_cast<U>(true)) operator Foo<U>();
};
template <typename T>
template <typename U>
Foo<T>::operator Foo<U>() {
return {};
}
int
main ()
{
Foo<float> a;
Foo<int> b = a; // { dg-error "conversion" }
}