[libcody] Remove some std::move [PR 98368]

Compiling on clang showed a couple of pessimizations.  Fixed thusly.

	libcody/
	* client.cc (Client::ProcessResponse): Remove std::move
	inside ?:
	c++tools/
	* resolver.cc (module_resolver::cmi_response): Remove
	std::move of temporary.
This commit is contained in:
Nathan Sidwell 2021-01-04 06:38:52 -08:00
parent 6bbc196c64
commit 6288183377
2 changed files with 2 additions and 5 deletions

View File

@ -226,9 +226,7 @@ module_resolver::cmi_response (Cody::Server *s, std::string &module)
auto iter = map.find (module);
if (iter == map.end ())
{
std::string file;
if (default_map)
file = std::move (GetCMIName (module));
std::string file = default_map ? GetCMIName (module) : std::string ();
auto res = map.emplace (module, file);
iter = res.first;
}

View File

@ -122,8 +122,7 @@ Packet Client::ProcessResponse (std::vector<std::string> &words,
Assert (!words.empty ());
if (words[0] == u8"ERROR")
return Packet (Client::PC_ERROR,
std::move (words.size () == 2 ? words[1]
: u8"malformed error response"));
words.size () == 2 ? words[1]: u8"malformed error response");
if (isLast && !read.IsAtEnd ())
return Packet (Client::PC_ERROR,