mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-04 02:40:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR c++/87519 - bogus warning with -Wsign-conversion.

Browse Source 
* typeck.c (cp_build_binary_op): Use same_type_p instead of comparing
	the types directly.

	* g++.dg/warn/Wsign-conversion-5.C: New test.

From-SVN: r274211
This commit is contained in:
Marek Polacek 2019-08-08 15:37:46 +00:00 committed by Marek Polacek
parent 7c81497574
commit 60bb944817
4 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/cp/ChangeLog
View File

@ -1,5 +1,9 @@
2019-08-08 Marek Polacek <polacek@redhat.com>
PR c++/87519 - bogus warning with -Wsign-conversion.
* typeck.c (cp_build_binary_op): Use same_type_p instead of comparing
the types directly.
* constexpr.c (inline_asm_in_constexpr_error): New.
(cxx_eval_constant_expression) <case ASM_EXPR>: Call it.
(potential_constant_expression_1) <case ASM_EXPR>: Likewise.

4
gcc/cp/typeck.c
View File

@ -5509,9 +5509,9 @@ cp_build_binary_op (const op_location_t &location,
if (! converted)
{
warning_sentinel w (warn_sign_conversion, short_compare);
if (TREE_TYPE (op0) != result_type)
if (!same_type_p (TREE_TYPE (op0), result_type))
op0 = cp_convert_and_check (result_type, op0, complain);
if (TREE_TYPE (op1) != result_type)
if (!same_type_p (TREE_TYPE (op1), result_type))
op1 = cp_convert_and_check (result_type, op1, complain);
if (op0 == error_mark_node || op1 == error_mark_node)

3
gcc/testsuite/ChangeLog
View File

@ -1,5 +1,8 @@
2019-08-08 Marek Polacek <polacek@redhat.com>
PR c++/87519 - bogus warning with -Wsign-conversion.
* g++.dg/warn/Wsign-conversion-5.C: New test.
* g++.dg/cpp2a/inline-asm3.C: New test.
2019-08-07 Steven G. Kargl <kargl@gcc.gnu.org>

18
gcc/testsuite/g++.dg/warn/Wsign-conversion-5.C Normal file
View File

@ -0,0 +1,18 @@
// PR c++/87519 - bogus warning with -Wsign-conversion.
// { dg-options "-Wsign-conversion" }
typedef unsigned long int uint64_t;
void f(unsigned long int a, int q)
{
a += a + q; // { dg-warning "may change the sign" }
// Explicit cast should disable the warning.
a = a + static_cast<uint64_t>(q);
a = a + (uint64_t) q;
a = a + uint64_t(q);
a = a + static_cast<const uint64_t>(q);
a = a + (const uint64_t) q;
a = a + static_cast<unsigned long int>(q);
a = a + static_cast<const unsigned long int>(q);
}