x86: Issue error for return/argument only with function body

If we never generate function body, we shouldn't issue errors for return
nor argument.  Add silent_p to i386 machine_function to avoid issuing
errors for return and argument without function body.

gcc/

	PR target/99652
	* config/i386/i386-options.c (ix86_init_machine_status): Set
	silent_p to true.
	* config/i386/i386.c (init_cumulative_args): Set silent_p to
	false.
	(construct_container): Return early for return and argument
	errors if silent_p is true.
	* config/i386/i386.h (machine_function): Add silent_p.

gcc/testsuite/

	PR target/99652
	* gcc.dg/torture/pr99652-1.c: New test.
	* gcc.dg/torture/pr99652-2.c: Likewise.
	* gcc.target/i386/pr57655.c: Adjusted.
	* gcc.target/i386/pr59794-6.c: Likewise.
	* gcc.target/i386/pr70738-1.c: Likewise.
	* gcc.target/i386/pr96744-1.c: Likewise.
This commit is contained in:
H.J. Lu 2021-03-18 11:47:46 -07:00
parent 21d09cb732
commit 5e2eabe1ee
9 changed files with 41 additions and 8 deletions

View File

@ -1768,6 +1768,7 @@ ix86_init_machine_status (void)
f = ggc_cleared_alloc<machine_function> ();
f->call_abi = ix86_abi;
f->stack_frame_required = true;
f->silent_p = true;
return f;
}

View File

@ -1705,6 +1705,10 @@ init_cumulative_args (CUMULATIVE_ARGS *cum, /* Argument info to initialize */
struct cgraph_node *local_info_node = NULL;
struct cgraph_node *target = NULL;
/* Set silent_p to false to raise an error for invalid calls when
expanding function body. */
cfun->machine->silent_p = false;
memset (cum, 0, sizeof (*cum));
if (fndecl)
@ -2534,6 +2538,10 @@ construct_container (machine_mode mode, machine_mode orig_mode,
some less clueful developer tries to use floating-point anyway. */
if (needed_sseregs && !TARGET_SSE)
{
/* Return early if we shouldn't raise an error for invalid
calls. */
if (cfun->machine->silent_p)
return NULL;
if (in_return)
{
if (!issued_sse_ret_error)
@ -2558,6 +2566,10 @@ construct_container (machine_mode mode, machine_mode orig_mode,
|| regclass[i] == X86_64_X87UP_CLASS
|| regclass[i] == X86_64_COMPLEX_X87_CLASS)
{
/* Return early if we shouldn't raise an error for invalid
calls. */
if (cfun->machine->silent_p)
return NULL;
if (!issued_x87_ret_error)
{
error ("x87 register return with x87 disabled");

View File

@ -2945,6 +2945,10 @@ struct GTY(()) machine_function {
function. */
BOOL_BITFIELD has_explicit_vzeroupper : 1;
/* True if we should act silently, rather than raise an error for
invalid calls. */
BOOL_BITFIELD silent_p : 1;
/* The largest alignment, in bytes, of stack slot actually used. */
unsigned int max_used_stack_alignment;

View File

@ -0,0 +1,8 @@
/* { dg-do compile { target i?86-*-* x86_64-*-* } } */
/* { dg-options "-mgeneral-regs-only" } */
inline double
foo (void)
{
return 1.0;
}

View File

@ -0,0 +1,8 @@
/* { dg-do compile { target i?86-*-* x86_64-*-* } } */
/* { dg-options "-mno-80387" } */
inline double
foo (void)
{
return 1.0;
}

View File

@ -2,7 +2,7 @@
/* { dg-options "-mavx -mvzeroupper -mno-fp-ret-in-387" } */
long double
foo (long double x)
{ /* { dg-error "x87 register return with x87 disabled" "" { target { ! ia32 } } } */
foo (long double x) /* { dg-error "x87 register return with x87 disabled" "" { target { ! ia32 } } } */
{
return __builtin_ilogbl (x);
}

View File

@ -8,7 +8,7 @@ typedef int __v4si __attribute__ ((__vector_size__ (16)));
extern __v4si x;
__v4si
foo (void)
{ /* { dg-error "SSE register return with SSE disabled" } */
foo (void) /* { dg-error "SSE register return with SSE disabled" } */
{
return x;
}

View File

@ -3,7 +3,7 @@
typedef int int32x2_t __attribute__ ((__vector_size__ ((8))));
int32x2_t test (int32x2_t a, int32x2_t b)
{ /* { dg-error "SSE register return with SSE disabled" } */
int32x2_t test (int32x2_t a, int32x2_t b) /* { dg-error "SSE register return with SSE disabled" } */
{
return a + b;
}

View File

@ -4,7 +4,7 @@
typedef int int32x2_t __attribute__ ((__vector_size__ ((8))));
__attribute__((__target__("general-regs-only")))
int32x2_t test (int32x2_t a, int32x2_t b)
{ /* { dg-error "SSE register return with SSE disabled" } */
int32x2_t test (int32x2_t a, int32x2_t b) /* { dg-error "SSE register return with SSE disabled" } */
{
return a + b;
}