mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-15 12:21:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR c++/5719 (Suspect gcc-3 to report wrong waring for 'T& T::operator+=( const T& )')

Browse Source 
cp:
	PR c++/5719
	* decl.c (grok_op_properties): Assignment ops don't have to return
	by value. operator% should.
testsuite:
	* g++.dg/warn/effc1.C: New test.

From-SVN: r52888
This commit is contained in:
Nathan Sidwell 2002-04-29 08:47:31 +00:00 committed by Nathan Sidwell
parent 53e72ddf6b
commit 4bd7c27025
4 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2002-04-29 Nathan Sidwell <nathan@codesourcery.com>
PR c++/5719
* decl.c (grok_op_properties): Assignment ops don't have to return
by value. operator% should.
2002-04-28 Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
PR c/6343

4
gcc/cp/decl.c
View File

@ -12677,10 +12677,12 @@ grok_op_properties (decl, friendp)
/* Effective C++ rule 23. */
if (warn_ecpp
&& arity == 2
&& !DECL_ASSIGNMENT_OPERATOR_P (decl)
&& (operator_code == PLUS_EXPR
|| operator_code == MINUS_EXPR
|| operator_code == TRUNC_DIV_EXPR
|| operator_code == MULT_EXPR)
|| operator_code == MULT_EXPR
|| operator_code == TRUNC_MOD_EXPR)
&& TREE_CODE (TREE_TYPE (TREE_TYPE (decl))) == REFERENCE_TYPE)
warning ("`%D' should return by value", decl);

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2002-04-29 Nathan Sidwell <nathan@codesourcery.com>
* g++.dg/warn/effc1.C: New test.
2002-04-29 Neil Booth <neil@daikokuya.demon.co.uk>
* gcc.dg/cpp/if-cexp.c: Add a test.

16
gcc/testsuite/g++.dg/warn/effc1.C Normal file
View File

@ -0,0 +1,16 @@
// { dg-options -Weffc++ }
// { dg-do compile }
// Copyright (C) 2001 Free Software Foundation, Inc.
// Contributed by Nathan Sidwell 26 Apr 2002 <nathan@codesourcery.com>
// Bug 5719
class A
{
public:
A & operator+=( int );
A & operator+( int ); // { dg-warning "`A& A::operator+(int)' should return by value" "" }
A operator+=( float );
A operator+( float );
};