mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-10 09:30:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

analyzer: further fixes for comparisons between uncomparable types (PR 93450)

Browse Source 
gcc/analyzer/ChangeLog:
	PR analyzer/93450
	* constraint-manager.cc
	(constraint_manager::get_or_add_equiv_class): Only compare constants
	if their types are compatible.
	* region-model.cc (constant_svalue::eval_condition): Replace check
	for identical types with call to types_compatible_p.
This commit is contained in:
David Malcolm 2020-01-30 15:21:28 -05:00
parent 95607c1236
commit 45eb3e4944
3 changed files with 13 additions and 2 deletions

9
gcc/analyzer/ChangeLog

@ -1,3 +1,12 @@
2020-01-31 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93450
* constraint-manager.cc
(constraint_manager::get_or_add_equiv_class): Only compare constants
if their types are compatible.
* region-model.cc (constant_svalue::eval_condition): Replace check
for identical types with call to types_compatible_p.
2020-01-30 David Malcolm <dmalcolm@redhat.com>
* program-state.cc (extrinsic_state::dump_to_pp): New.

4
gcc/analyzer/constraint-manager.cc

@ -958,7 +958,9 @@ constraint_manager::get_or_add_equiv_class (svalue_id sid)
other_id.m_idx++)
{
const equiv_class &other_ec = other_id.get_obj (*this);
if (other_ec.m_constant)
if (other_ec.m_constant
&& types_compatible_p (TREE_TYPE (new_ec->m_constant),
TREE_TYPE (other_ec.m_constant)))
{
/* If we have two ECs, both with constants, the constants must be
non-equal (or they would be in the same EC).

2
gcc/analyzer/region-model.cc

@ -667,7 +667,7 @@ constant_svalue::eval_condition (constant_svalue *lhs,
gcc_assert (CONSTANT_CLASS_P (rhs_const));
/* Check for comparable types. */
if (TREE_TYPE (lhs_const) == TREE_TYPE (rhs_const))
if (types_compatible_p (TREE_TYPE (lhs_const), TREE_TYPE (rhs_const)))
{
tree comparison
= fold_build2 (op, boolean_type_node, lhs_const, rhs_const);