mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-19 18:20:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR c++/61489 (Wrong warning with -Wmissing-field-initializers.)

Browse Source 
2014-09-11  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/61489
	* doc/invoke.texi ([-Wmissing-field-initializers]): Update.

/cp
2014-09-11  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/61489
	* typeck2.c (process_init_constructor_record): Do not warn about
	missing field initializer if EMPTY_CONSTRUCTOR_P (init).

/testsuite
2014-09-11  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/61489
	* g++.dg/warn/Wmissing-field-initializers-1.C: New.
	* g++.old-deja/g++.other/warn5.C: Adjust.

From-SVN: r215186
This commit is contained in:
Paolo Carlini 2014-09-11 18:08:24 +00:00 committed by Paolo Carlini
parent bc138f7bee
commit 450bfd7d5c
7 changed files with 61 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2014-09-11 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/61489
* doc/invoke.texi ([-Wmissing-field-initializers]): Update.
2014-09-11 Alan Lawrence <alan.lawrence@arm.com>
* config/aarch64/aarch64-builtins.c (aarch64_types_unop_su_qualifiers,

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2014-09-11 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/61489
* typeck2.c (process_init_constructor_record): Do not warn about
missing field initializer if EMPTY_CONSTRUCTOR_P (init).
2014-09-11 Jason Merrill <jason@redhat.com>
PR c++/63139

6
gcc/cp/typeck2.c
View File

@ -1359,7 +1359,8 @@ process_init_constructor_record (tree type, tree init,
next = massage_init_elt (TREE_TYPE (field), next, complain);
/* Warn when some struct elements are implicitly initialized. */
if (complain & tf_warning)
if ((complain & tf_warning)
&& !EMPTY_CONSTRUCTOR_P (init))
warning (OPT_Wmissing_field_initializers,
"missing initializer for member %qD", field);
}
@ -1382,7 +1383,8 @@ process_init_constructor_record (tree type, tree init,
/* Warn when some struct elements are implicitly initialized
to zero. */
if (complain & tf_warning)
if ((complain & tf_warning)
&& !EMPTY_CONSTRUCTOR_P (init))
warning (OPT_Wmissing_field_initializers,
"missing initializer for member %qD", field);

8
gcc/doc/invoke.texi
View File

@ -4912,6 +4912,14 @@ struct s @{ int f, g, h; @};
struct s x = @{ .f = 3, .g = 4 @};
@end smallexample
In C++ this option does not warn either about the empty @{ @}
initializer, for example:
@smallexample
struct s @{ int f, g, h; @};
s x = @{ @};
@end smallexample
This warning is included in @option{-Wextra}. To get other @option{-Wextra}
warnings without this one, use @option{-Wextra -Wno-missing-field-initializers}.

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2014-09-11 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/61489
* g++.dg/warn/Wmissing-field-initializers-1.C: New.
* g++.old-deja/g++.other/warn5.C: Adjust.
2014-09-11 Alan Lawrence <alan.lawrence@arm.com>
* gcc.target/aarch64/vset_lane_1.c: New test.

31
gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-1.C Normal file
View File

@ -0,0 +1,31 @@
// PR c++/61489
// { dg-options "-Wmissing-field-initializers" }
struct mystruct1 {
int a, b;
};
struct aux2 {
aux2();
};
struct mystruct2 {
aux2 a, b;
};
struct aux3 {
int x;
};
struct mystruct3 {
aux3 a, b;
};
mystruct1 obj11 = {};
mystruct1 obj12 = {0}; // { dg-warning "missing initializer" }
mystruct2 obj21 = {};
mystruct2 obj22 = {aux2()}; // { dg-warning "missing initializer" }
mystruct3 obj31 = {};
mystruct3 obj32 = {0}; // { dg-warning "missing initializer" }

2
gcc/testsuite/g++.old-deja/g++.other/warn5.C
View File

@ -16,4 +16,4 @@ X *foo ()
return new X (); // gets bogus warning
}
X x = {}; // { dg-warning "" } missing initializer
X x = {};