From 42b40eff8019d80a429d26616e80db96f1cb882c Mon Sep 17 00:00:00 2001 From: Paolo Carlini Date: Thu, 25 Oct 2012 16:14:59 +0000 Subject: [PATCH] re PR c++/53761 (ICE on incorrect transparent union (first field has floating point type)) /cp 2012-10-25 Paolo Carlini PR c++/53761 * class.c (finish_struct_1): Reject aggregates decorated with __transparent_union__ which cannot be made transparent because the type of the first field has a different ABI from the class overall. /testsuite 2012-10-25 Paolo Carlini PR c++/53761 * g++.dg/ext/transparent-union.C: New. From-SVN: r192814 --- gcc/cp/ChangeLog | 8 ++++++++ gcc/cp/class.c | 9 ++++++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/ext/transparent-union.C | 5 +++++ 4 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/ext/transparent-union.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 458f39abc7e2..3cd3b27bc17b 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,11 @@ +2012-10-25 Paolo Carlini + + PR c++/53761 + * class.c (finish_struct_1): Reject aggregates decorated with + __transparent_union__ which cannot be made transparent because + the type of the first field has a different ABI from the class + overall. + 2012-10-25 Jason Merrill Core 1402 diff --git a/gcc/cp/class.c b/gcc/cp/class.c index 3e1b44a4c1ec..e55f1f9c2b78 100644 --- a/gcc/cp/class.c +++ b/gcc/cp/class.c @@ -6267,7 +6267,7 @@ finish_struct_1 (tree t) tree field = first_field (t); if (field == NULL_TREE || error_operand_p (field)) { - error ("type transparent class %qT does not have any fields", t); + error ("type transparent %q#T does not have any fields", t); TYPE_TRANSPARENT_AGGR (t) = 0; } else if (DECL_ARTIFICIAL (field)) @@ -6281,6 +6281,13 @@ finish_struct_1 (tree t) } TYPE_TRANSPARENT_AGGR (t) = 0; } + else if (TYPE_MODE (t) != DECL_MODE (field)) + { + error ("type transparent %q#T cannot be made transparent because " + "the type of the first field has a different ABI from the " + "class overall", t); + TYPE_TRANSPARENT_AGGR (t) = 0; + } } } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 30fced628560..16c0ce6c1b9f 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-10-25 Paolo Carlini + + PR c++/53761 + * g++.dg/ext/transparent-union.C: New. + 2012-10-25 Marc Glisse PR c++/54427 diff --git a/gcc/testsuite/g++.dg/ext/transparent-union.C b/gcc/testsuite/g++.dg/ext/transparent-union.C new file mode 100644 index 000000000000..12315636100c --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/transparent-union.C @@ -0,0 +1,5 @@ +// PR c++/53761 + +typedef union { // { dg-error "type transparent" } + double x; +} __attribute__(( __transparent_union__ )) example_t;