mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-05 05:20:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

arm: Fix up neon_vector_mem_operand [PR97528]

Browse Source 
The documentation for POST_MODIFY says:
   Currently, the compiler can only handle second operands of the
   form (plus (reg) (reg)) and (plus (reg) (const_int)), where
   the first operand of the PLUS has to be the same register as
   the first operand of the *_MODIFY.
The following testcase ICEs, because combine just attempts to simplify
things and ends up with
(post_modify (reg1) (plus (mult (reg2) (const_int 4)) (reg1))
but the target predicates accept it, because they only verify
that POST_MODIFY's second operand is PLUS and the second operand
of the PLUS is a REG.

The following patch fixes this by performing further verification that
the POST_MODIFY is in the form it should be.

2020-11-20  Jakub Jelinek  <jakub@redhat.com>

	PR target/97528
	* config/arm/arm.c (neon_vector_mem_operand): For POST_MODIFY, require
	first POST_MODIFY operand is a REG and is equal to the first operand
	of PLUS.

	* gcc.target/arm/pr97528.c: New test.
This commit is contained in:
Jakub Jelinek 2020-11-20 12:26:58 +01:00
parent 1b3c981367
commit 410b8f6f41
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/config/arm/arm.c
View File

@ -13429,7 +13429,9 @@ neon_vector_mem_operand (rtx op, int type, bool strict)
/* Allow post-increment by register for VLDn */
if (type == 2 && GET_CODE (ind) == POST_MODIFY
&& GET_CODE (XEXP (ind, 1)) == PLUS
&& REG_P (XEXP (XEXP (ind, 1), 1)))
&& REG_P (XEXP (XEXP (ind, 1), 1))
&& REG_P (XEXP (ind, 0))
&& rtx_equal_p (XEXP (ind, 0), XEXP (XEXP (ind, 1), 0)))
return true;
/* Match:

28
gcc/testsuite/gcc.target/arm/pr97528.c Normal file
View File

@ -0,0 +1,28 @@
/* PR target/97528 */
/* { dg-do compile } */
/* { dg-require-effective-target arm_neon_ok } */
/* { dg-options "-O1" } */
/* { dg-add-options arm_neon } */
#include <arm_neon.h>
typedef __simd64_int16_t T;
typedef __simd64_uint16_t U;
unsigned short c;
int d;
U e;
void
foo (void)
{
unsigned short *dst = &c;
int g = d, b = 4;
U dc = e;
for (int h = 0; h < b; h++)
{
unsigned short *i = dst;
U j = dc;
vst1_s16 ((int16_t *) i, (T) j);
dst += g;
}
}