mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-10 20:41:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

c++: Hard error with tentative parse of declaration [PR88754]

Browse Source 
In the testcase for this PR, we try to parse the statement

  A(value<0>());

first tentatively as a declaration (with a parenthesized declarator), and during
this tentative parse we end up issuing a hard error from
cp_parser_check_template_parameters about its invalidness as a declaration.

Rather than issuing a hard error, it seems we should instead simulate an error
since we're parsing tentatively.  This would then allow cp_parser_statement to
recover and successfully parse the statement as an expression-statement instead.

gcc/cp/ChangeLog:

	PR c++/88754
	* parser.c (cp_parser_check_template_parameters): Before issuing a hard
	error, first try simulating an error instead.

gcc/testsuite/ChangeLog:

	PR c++/88754
	* g++.dg/parse/ambig10.C: New test.
This commit is contained in:
Patrick Palka 2020-04-16 16:45:15 -04:00
parent 2298af0800
commit 3f5af3f711
4 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2020-04-17 Patrick Palka <ppalka@redhat.com>
PR c++/88754
* parser.c (cp_parser_check_template_parameters): Before issuing a hard
error, first try simulating an error instead.
2020-04-17 Jakub Jelinek <jakub@redhat.com>
PR other/94629

4
gcc/cp/parser.c
View File

@ -28530,6 +28530,10 @@ cp_parser_check_template_parameters (cp_parser* parser,
if (!template_id_p
&& parser->num_template_parameter_lists == num_templates + 1)
return true;
if (cp_parser_simulate_error (parser))
return false;
/* If there are more template classes than parameter lists, we have
something like:

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-04-17 Patrick Palka <ppalka@redhat.com>
PR c++/88754
* g++.dg/parse/ambig10.C: New test.
2020-04-17 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/94090

20
gcc/testsuite/g++.dg/parse/ambig10.C Normal file
View File

@ -0,0 +1,20 @@
// PR c++/88754
// { dg-do compile }
struct A
{
A(int);
void foo();
};
template<int N> int value() { return N; }
void bar()
{
A(value<0>()).foo();
A(value<0>());
(A(value<0>())).foo();
A value<0>; // { dg-error "invalid declaration" }
A value<0>(); // { dg-error "invalid declaration" }
}