From 30a390c8104f9530cd8721e699deecd823fc4e9c Mon Sep 17 00:00:00 2001 From: Paul Thomas Date: Sat, 8 Oct 2011 10:18:51 +0000 Subject: [PATCH] re PR fortran/47844 (Array stride ignored for pointer-valued function results) 2011-10-08 Paul Thomas PR fortran/47844 * trans-array.c (gfc_conv_array_index_offset): Use descriptor stride for pointer function results. 2011-10-08 Paul Thomas PR fortran/47844 * gfortran.dg/pointer_function_result_1.f90 : New test. From-SVN: r179710 --- gcc/fortran/ChangeLog | 6 ++++ gcc/fortran/trans-array.c | 12 ++++++++ gcc/testsuite/ChangeLog | 5 ++++ .../gfortran.dg/pointer_function_result_1.f90 | 28 +++++++++++++++++++ 4 files changed, 51 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pointer_function_result_1.f90 diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index a4e1c5f8c4e8..2c09f9aeef62 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,9 @@ +2011-10-08 Paul Thomas + + PR fortran/47844 + * trans-array.c (gfc_conv_array_index_offset): Use descriptor + stride for pointer function results. + 2011-10-07 Mikael Morin * trans-array.c (gfc_conv_expr_descriptor): Remove trailing whitespace. diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c index 79dbafa29f41..b7556704ca19 100644 --- a/gcc/fortran/trans-array.c +++ b/gcc/fortran/trans-array.c @@ -2609,6 +2609,18 @@ gfc_conv_array_index_offset (gfc_se * se, gfc_ss_info * info, int dim, int i, /* Temporary array or derived type component. */ gcc_assert (se->loop); index = se->loop->loopvar[se->loop->order[i]]; + + /* Pointer functions can have stride[0] different from unity. + Use the stride returned by the function call and stored in + the descriptor for the temporary. */ + if (se->ss && se->ss->type == GFC_SS_FUNCTION + && se->ss->expr + && se->ss->expr->symtree + && se->ss->expr->symtree->n.sym->result + && se->ss->expr->symtree->n.sym->result->attr.pointer) + stride = gfc_conv_descriptor_stride_get (info->descriptor, + gfc_rank_cst[dim]); + if (!integer_zerop (info->delta[dim])) index = fold_build2_loc (input_location, PLUS_EXPR, gfc_array_index_type, index, info->delta[dim]); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ea79b6075fb5..02a8ffd119e8 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-10-08 Paul Thomas + + PR fortran/47844 + * gfortran.dg/pointer_function_result_1.f90 : New test. + 2011-10-07 David S. Miller PR 50655 diff --git a/gcc/testsuite/gfortran.dg/pointer_function_result_1.f90 b/gcc/testsuite/gfortran.dg/pointer_function_result_1.f90 new file mode 100644 index 000000000000..764a666be963 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pointer_function_result_1.f90 @@ -0,0 +1,28 @@ +! { dg-do run } +! Test the fix for PR47844, in which the stride in the function result +! was ignored. Previously, the result was [1,3] at lines 15 and 16. +! +! Contributed by KePu +! +PROGRAM test_pointer_value + IMPLICIT NONE + INTEGER, DIMENSION(10), TARGET :: array= [1,3,5,7,9,11,13,15,17,19] + INTEGER, dimension(2) :: array_fifth + INTEGER, POINTER, DIMENSION(:) :: ptr_array => NULL() + INTEGER, POINTER, DIMENSION(:) :: ptr_array_fifth => NULL() + ptr_array => array + array_fifth = every_fifth (ptr_array) + if (any (array_fifth .ne. [1,11])) call abort + if (any (every_fifth(ptr_array) .ne. [1,11])) call abort +CONTAINS + FUNCTION every_fifth (ptr_array) RESULT (ptr_fifth) + IMPLICIT NONE + INTEGER, POINTER, DIMENSION(:) :: ptr_fifth + INTEGER, POINTER, DIMENSION(:), INTENT(in) :: ptr_array + INTEGER :: low + INTEGER :: high + low = LBOUND (ptr_array, 1) + high = UBOUND (ptr_array, 1) + ptr_fifth => ptr_array (low: high: 5) + END FUNCTION every_fifth +END PROGRAM test_pointer_value