c++: inlining explicit instantiations [PR104539]

The PR10968 fix cleared DECL_COMDAT to force output of explicit
instantiations.  Then the PR59469 fix added a call to mark_needed, after
which we no longer need to clear DECL_COMDAT, and leaving it set allows us
to inline explicit instantiations without worrying about symbol
interposition.

I suppose there's an argument to be made that an explicit instantiation
declaration (extern template) should clear DECL_COMDAT, since that suggests
that there will be only a single instantiation somewhere that could be
subject to interposition, but that doesn't change the 'inline' semantics,
and it seems cleaner to treat template instantiations uniformly.

	PR c++/104539

gcc/cp/ChangeLog:

	* pt.cc (mark_decl_instantiated): Don't clear DECL_COMDAT.

gcc/testsuite/ChangeLog:

	* g++.dg/ipa/inline-4.C: New test.
This commit is contained in:
Jason Merrill 2022-02-17 00:04:21 -05:00
parent 1b71bc7c8b
commit 2c9b7077b7
2 changed files with 15 additions and 3 deletions

View File

@ -24726,9 +24726,6 @@ mark_decl_instantiated (tree result, int extern_p)
set correctly by tsubst. */
TREE_PUBLIC (result) = 1;
/* This might have been set by an earlier implicit instantiation. */
DECL_COMDAT (result) = 0;
if (extern_p)
{
DECL_EXTERNAL (result) = 1;

View File

@ -0,0 +1,15 @@
// PR c++/104539
// { dg-additional-options "-O3 -fdump-ipa-inline" }
// { dg-final { scan-ipa-dump-not "overwritten at link time" "inline" } }
template <int>
//inline
int f() {
return 0;
}
template int f<0>();
int g() {
return f<0>() + 1;
}