mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-11 03:50:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

pass_manager: Fix ICE with -fdump-passes -fdisable-tree-* [PR93874]

Browse Source 
dump_passes pushes a dummy function for which it evaluates the gates
and checks whether the pass is enabled or disabled.
Unfortunately, if any -fdisable-*-*/-fenable-*-* options were seen,
we ICE during is_pass_explicitly_enabled_or_disabled because slot
is non-NULL then and the code will do:
  cgraph_uid = func ? cgraph_node::get (func)->get_uid () : 0;
but the dummy function doesn't have a cgraph node.

So, either we need to create and then remove a cgraph node for the dummy
function like the following patch, or function.c would need to export the
in_dummy_function flag (or have some way to query that flag from other TUs)
and we'd need to check it in is_pass_explicitly_enabled_or_disabled.

2020-02-25  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/93874
	* passes.c (pass_manager::dump_passes): Create a cgraph node for the
	dummy function and remove it at the end.

	* gcc.dg/pr93874.c: New test.
This commit is contained in:
Jakub Jelinek 2020-02-25 10:21:34 +01:00
parent fe86f537f0
commit 2473c81cb2
4 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/ChangeLog
View File

@ -1,5 +1,9 @@
2020-02-25 Jakub Jelinek <jakub@redhat.com>
PR middle-end/93874
* passes.c (pass_manager::dump_passes): Create a cgraph node for the
dummy function and remove it at the end.
PR translation/93864
* config/lm32/lm32.c (lm32_setup_incoming_varargs): Fix comment typo
paramter -> parameter.

2
gcc/passes.c
View File

@ -950,6 +950,7 @@ void
pass_manager::dump_passes () const
{
push_dummy_function (true);
cgraph_node *node = cgraph_node::get_create (current_function_decl);
create_pass_tab ();
@ -959,6 +960,7 @@ pass_manager::dump_passes () const
dump_pass_list (all_late_ipa_passes, 1);
dump_pass_list (all_passes, 1);
node->remove ();
pop_dummy_function ();
}

3
gcc/testsuite/ChangeLog
View File

@ -1,5 +1,8 @@
2020-02-25 Jakub Jelinek <jakub@redhat.com>
PR middle-end/93874
* gcc.dg/pr93874.c: New test.
PR ipa/93763
* gcc.dg/ipa/pr93763.c: Adjust the test so that it compiles without
warnings and still ICEs before the ipa-cp.c fix.

6
gcc/testsuite/gcc.dg/pr93874.c Normal file
View File

@ -0,0 +1,6 @@
/* PR middle-end/93874 */
/* { dg-do compile } */
/* { dg-options "-fdisable-tree-dse3 -fdump-passes" } */
/* { dg-prune-output ".*" } */
int i;