From 2409cb3750cf2392184f599b122c9ccc0c0fb26d Mon Sep 17 00:00:00 2001 From: Kelley Cook Date: Thu, 2 Oct 2003 00:07:50 +0000 Subject: [PATCH] /tmp/cvs001644 From-SVN: r72005 --- gcc/ChangeLog | 5 +++++ gcc/c-parse.in | 5 ++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/Wold-style-definition-2.c | 10 ++++++++++ gcc/testsuite/gcc.dg/wtr-func-def-1.c | 8 ++++---- 5 files changed, 28 insertions(+), 5 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/Wold-style-definition-2.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5dbe87feb71c..ce865fe99ae6 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2003-10-01 Kelley Cook + + PR C/12466 + * c-parse.in (parmlist_2): Mark declaration with an ellipsis as ISO C. + 2003-10-01 Rainer Orth * config/mips/xm-iris5.h: Remove, unnecessary. diff --git a/gcc/c-parse.in b/gcc/c-parse.in index 2d3eef84a86d..0ae20c1b1f48 100644 --- a/gcc/c-parse.in +++ b/gcc/c-parse.in @@ -2561,13 +2561,16 @@ parmlist_2: /* empty */ tries to verify that BUILT_IN_NEXT_ARG is being used correctly. */ error ("ISO C requires a named argument before `...'"); + parsing_iso_function_signature = true; } | parms { $$ = get_parm_info (1); parsing_iso_function_signature = true; } | parms ',' ELLIPSIS - { $$ = get_parm_info (0); } + { $$ = get_parm_info (0); + parsing_iso_function_signature = true; + } ; parms: diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8a6a2573b4bc..69a716e69090 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2003-10-01 Kelley Cook + + * gcc.dg/Wold-style-definition-2.c: New testcase. + * gcc.dg/wtr-func-def-1.c: Modify to reflect new warning. + 2003-09-29 Richard Henderson * g++.dg/init/array10.C: Add dg-options. diff --git a/gcc/testsuite/gcc.dg/Wold-style-definition-2.c b/gcc/testsuite/gcc.dg/Wold-style-definition-2.c new file mode 100644 index 000000000000..a69aae6fd276 --- /dev/null +++ b/gcc/testsuite/gcc.dg/Wold-style-definition-2.c @@ -0,0 +1,10 @@ +/* PR c/12466 + Test for not warning about ellipsises with -Wold-style-definition. */ + +/* Origin: Kelley Cook */ +/* { dg-do compile } */ +/* { dg-options "-Wold-style-definition" } */ + +void bar1 ( ... ) {} /* { dg-error "ISO C requires a named argument" } */ + +void bar2 (int a, ... ) {} diff --git a/gcc/testsuite/gcc.dg/wtr-func-def-1.c b/gcc/testsuite/gcc.dg/wtr-func-def-1.c index c300d22ee3e0..32d613ea748b 100644 --- a/gcc/testsuite/gcc.dg/wtr-func-def-1.c +++ b/gcc/testsuite/gcc.dg/wtr-func-def-1.c @@ -143,21 +143,21 @@ f_impl3(int f) return 0; } -/* Test that we don't warn about stdarg functions. */ +/* Test stdarg functions. */ f_stdarg1(const char *s, ...) -{ +{ /* { dg-warning "traditional C rejects ISO C style" } */ return 0; } void f_stdarg2(const char *s, ...) -{ +{ /* { dg-warning "traditional C rejects ISO C style" } */ return; } extern void f_stdarg3(const char *, ...); void f_stdarg3(const char *s, ...) -{ +{ /* { dg-warning "traditional C rejects ISO C style" } */ return; }