mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-03-31 15:31:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

re PR c++/67767 (-Wsuggest-attribute=noreturn suggests noreturn for function which already has noreturn and cold.)

Browse Source 
PR c++/67767
	* parser.c (cp_parser_std_attribute_spec_seq): Don't assume
	attr_spec is always single element chain, chain all the attributes
	properly together in the right order.

	* g++.dg/cpp0x/pr67767.C: New test.

From-SVN: r233560
This commit is contained in:
Jakub Jelinek 2016-02-19 17:01:50 +01:00 committed by Jakub Jelinek
parent 2db16594fe
commit 19e2158623
4 changed files with 29 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/cp/ChangeLog
View File

@ -1,3 +1,10 @@
2016-02-19 Jakub Jelinek <jakub@redhat.com>
PR c++/67767
* parser.c (cp_parser_std_attribute_spec_seq): Don't assume
attr_spec is always single element chain, chain all the attributes
properly together in the right order.
2016-02-18 Jason Merrill <jason@redhat.com>
* mangle.c (maybe_check_abi_tags): Add for_decl parm. Call

11
gcc/cp/parser.c
View File

@ -24104,7 +24104,8 @@ cp_parser_std_attribute_spec (cp_parser *parser)
static tree
cp_parser_std_attribute_spec_seq (cp_parser *parser)
{
tree attr_specs = NULL;
tree attr_specs = NULL_TREE;
tree attr_last = NULL_TREE;
while (true)
{
@ -24114,11 +24115,13 @@ cp_parser_std_attribute_spec_seq (cp_parser *parser)
if (attr_spec == error_mark_node)
return error_mark_node;
TREE_CHAIN (attr_spec) = attr_specs;
attr_specs = attr_spec;
if (attr_last)
TREE_CHAIN (attr_last) = attr_spec;
else
attr_specs = attr_last = attr_spec;
attr_last = tree_last (attr_last);
}
attr_specs = nreverse (attr_specs);
return attr_specs;
}

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2016-02-19 Jakub Jelinek <jakub@redhat.com>
PR c++/67767
* g++.dg/cpp0x/pr67767.C: New test.
2016-02-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* lib/target-supports.exp: Define aarch64_asm_FUNC_ok checks

10
gcc/testsuite/g++.dg/cpp0x/pr67767.C Normal file
View File

@ -0,0 +1,10 @@
// PR c++/67767
// { dg-do compile { target c++11 } }
// { dg-options "-Wsuggest-attribute=noreturn" }
void foo [[gnu::cold, gnu::noreturn]] ();
void foo () // { dg-bogus "function might be candidate for attribute" }
{
throw 1;
}