From 0b86a6438191f720bebf880a2b932cd97d10229a Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Thu, 25 Mar 2021 21:06:09 +0100 Subject: [PATCH] c++: Diagnose bare parameter packs in bitfield widths [PR99745] The following invalid tests ICE because we don't diagnose (and drop) bare parameter packs in bitfield widths. 2021-03-25 Jakub Jelinek PR c++/99745 * decl2.c (grokbitfield): Diagnose bitfields containing bare parameter packs and don't set DECL_BIT_FIELD_REPRESENTATIVE in that case. * g++.dg/cpp0x/variadic181.C: New test. --- gcc/cp/decl2.c | 2 +- gcc/testsuite/g++.dg/cpp0x/variadic181.C | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/variadic181.C diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index ef79f6cc6d12..a82960fb39c0 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -1117,7 +1117,7 @@ grokbitfield (const cp_declarator *declarator, && !INTEGRAL_OR_UNSCOPED_ENUMERATION_TYPE_P (TREE_TYPE (width))) error ("width of bit-field %qD has non-integral type %qT", value, TREE_TYPE (width)); - else + else if (!check_for_bare_parameter_packs (width)) { /* Temporarily stash the width in DECL_BIT_FIELD_REPRESENTATIVE. check_bitfield_decl picks it from there later and sets DECL_SIZE diff --git a/gcc/testsuite/g++.dg/cpp0x/variadic181.C b/gcc/testsuite/g++.dg/cpp0x/variadic181.C new file mode 100644 index 000000000000..0bb6fe7a8f33 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/variadic181.C @@ -0,0 +1,9 @@ +// PR c++/99745 +// { dg-do compile { target c++11 } } + +template +struct S { int a : sizeof(Ts); }; // { dg-error "parameter packs not expanded with '\.\.\.':" } +S s; // { dg-message "'Ts'" "" { target *-*-* } .-1 } +template +struct T { int a : Ns; }; // { dg-error "parameter packs not expanded with '\.\.\.':" } +T<0> t; // { dg-message "'Ns'" "" { target *-*-* } .-1 }