mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-15 16:31:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

analyzer: fix ICE handling void-type (PR 93373)

Browse Source 
gcc/analyzer/ChangeLog:
	PR analyzer/93373
	* region-model.cc (ASSERT_COMPAT_TYPES): Convert to...
	(assert_compat_types): ...this, and bail when either type is NULL,
	or when VOID_TYPE_P (dst_type).
	(region_model::get_lvalue): Update for above conversion.
	(region_model::get_rvalue): Likewise.

gcc/testsuite/ChangeLog:
	PR analyzer/93373
	* gcc.dg/analyzer/torture/pr93373.c: New test.
This commit is contained in:
David Malcolm 2020-01-22 13:08:26 -05:00
parent 2a07345c4f
commit 09bea5845a
4 changed files with 25 additions and 4 deletions
gcc
analyzer
ChangeLogregion-model.cc
testsuite
ChangeLog
gcc.dg/analyzer/torture
pr93373.c

9
gcc/analyzer/ChangeLog

@ -1,3 +1,12 @@
2020-01-31 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93373
* region-model.cc (ASSERT_COMPAT_TYPES): Convert to...
(assert_compat_types): ...this, and bail when either type is NULL,
or when VOID_TYPE_P (dst_type).
(region_model::get_lvalue): Update for above conversion.
(region_model::get_rvalue): Likewise.
2020-01-31 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93379

12
gcc/analyzer/region-model.cc

@ -4701,8 +4701,12 @@ region_model::get_lvalue_1 (path_var pv, region_model_context *ctxt)
/* Assert that SRC_TYPE can be converted to DST_TYPE as a no-op. */
#define ASSERT_COMPAT_TYPES(SRC_TYPE, DST_TYPE) \
gcc_checking_assert (useless_type_conversion_p ((SRC_TYPE), (DST_TYPE)))
static void
assert_compat_types (tree src_type, tree dst_type)
{
if (src_type && dst_type && !VOID_TYPE_P (dst_type))
gcc_checking_assert (useless_type_conversion_p (src_type, dst_type));
}
/* Get the id of the region for PV within this region_model,
emitting any diagnostics to CTXT. */
@ -4714,7 +4718,7 @@ region_model::get_lvalue (path_var pv, region_model_context *ctxt)
return region_id::null ();
region_id result_rid = get_lvalue_1 (pv, ctxt);
ASSERT_COMPAT_TYPES (get_region (result_rid)->get_type (),
assert_compat_types (get_region (result_rid)->get_type (),
TREE_TYPE (pv.m_tree));
return result_rid;
}
@ -4795,7 +4799,7 @@ region_model::get_rvalue (path_var pv, region_model_context *ctxt)
return svalue_id::null ();
svalue_id result_sid = get_rvalue_1 (pv, ctxt);
ASSERT_COMPAT_TYPES (get_svalue (result_sid)->get_type (),
assert_compat_types (get_svalue (result_sid)->get_type (),
TREE_TYPE (pv.m_tree));
return result_sid;

5
gcc/testsuite/ChangeLog

@ -1,3 +1,8 @@
2020-01-31 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93373
* gcc.dg/analyzer/torture/pr93373.c: New test.
2020-01-31 Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/91333

3
gcc/testsuite/gcc.dg/analyzer/torture/pr93373.c Normal file

@ -0,0 +1,3 @@
/* { dg-do compile }
{ dg-require-effective-target alloca } */
#include "../../Warray-bounds-41.c"