mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-02-19 11:10:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR target/28648 c:

Browse Source 
* tree.c (handle_dll_attribute): Return early if not a
   	var or function decl.

testsuite
	* gcc.dg/attr-invalid.c: Add tests for invalid dllimport.

From-SVN: r116270
This commit is contained in:
Danny Smith 2006-08-20 08:46:13 +00:00 committed by Danny Smith
parent 3e978d3094
commit 09416794b7
4 changed files with 42 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
006-08-20 Danny Smith <dannysmith@users.sourceforge.net>
PR target/28648 c:
* tree.c (handle_dll_attribute): Return early if not a
var or function decl.
2006-08-18 Joseph Myers <joseph@codesourcery.com>
PR target/27565

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2006-08-20 Danny Smith <dannysmith@users.sourceforge.net>
PR target/28648 c:
* gcc.dg/attr-invalid.c: Add tests for invalid dllimport.
2006-08-20 Paul Thomas <pault@gcc.gnu.org>
PR fortran/28630

21
gcc/testsuite/gcc.dg/attr-invalid.c
View File

@ -77,3 +77,24 @@ int ATSYM(fn_knrarg) (arg)
{ return 0; }
int ATSYM(fn_isoarg) (int arg ATTR) { return 0; } /* { dg-warning "attribute ignored" "" } */
/* PR target/28648 */
/* These are invalid on all targets. Applying to PARM_ or FIELD_DECL
also caused a tree checking ice on targets that support dllimport. */
#undef AT
#define AT dllimport
typedef int ATSYM(type) ATTR; /* { dg-warning "attribute ignored" "" } */
typedef int (*ATSYM(fntype))(void) ATTR; /* { dg-warning "attribute ignored" "" } */
struct ATSYM(struct) {
char dummy ATTR; /* { dg-warning "attribute ignored" "" } */
};
int ATSYM(fn_knrarg) (arg)
int arg ATTR; /* { dg-warning "attribute ignored" "" } */
{ return 0; }
int ATSYM(fn_isoarg) (int arg ATTR) { return 0; } /* { dg-warning "attribute ignored" "" } */

11
gcc/tree.c
View File

@ -3706,9 +3706,18 @@ handle_dll_attribute (tree * pnode, tree name, tree args, int flags,
return NULL_TREE;
}
if (TREE_CODE (node) != FUNCTION_DECL
&& TREE_CODE (node) != VAR_DECL)
{
*no_add_attrs = true;
warning (OPT_Wattributes, "%qs attribute ignored",
IDENTIFIER_POINTER (name));
return NULL_TREE;
}
/* Report error on dllimport ambiguities seen now before they cause
any damage. */
if (is_attribute_p ("dllimport", name))
else if (is_attribute_p ("dllimport", name))
{
/* Honor any target-specific overrides. */
if (!targetm.valid_dllimport_attribute_p (node))