c-common.c: Change warning messages to say comparison is always true' or comparison is...

* c-common.c: Change warning messages to say `comparison is
        always true' or `comparison is always false' instead of the
        confusing `is always 0', `is always 1'.

From-SVN: r23723
This commit is contained in:
Zack Weinberg 1998-11-19 19:40:56 +00:00 committed by Jeff Law
parent 74285159e4
commit 07be2a2372
2 changed files with 12 additions and 6 deletions

View File

@ -1,3 +1,9 @@
1998-11-19 Zack Weinberg <zack@rabi.phys.columbia.edu>
* c-common.c: Change warning messages to say `comparison is
always true' or `comparison is always false' instead of the
confusing `is always 0', `is always 1'.
Thu Nov 19 19:05:49 1998 Per Bothner <bothner@cygnus.com>
* print-tree.c (print_node): After printing BLOCK or BIND_EXPR,

View File

@ -2512,18 +2512,18 @@ shorten_compare (op0_ptr, op1_ptr, restype_ptr, rescode_ptr)
/* This is the case of (char)x >?< 0x80, which people used to use
expecting old C compilers to change the 0x80 into -0x80. */
if (val == boolean_false_node)
warning ("comparison is always 0 due to limited range of data type");
warning ("comparison is always false due to limited range of data type");
if (val == boolean_true_node)
warning ("comparison is always 1 due to limited range of data type");
warning ("comparison is always true due to limited range of data type");
}
if (!min_lt && unsignedp0 && TREE_CODE (primop0) != INTEGER_CST)
{
/* This is the case of (unsigned char)x >?< -1 or < 0. */
if (val == boolean_false_node)
warning ("comparison is always 0 due to limited range of data type");
warning ("comparison is always false due to limited range of data type");
if (val == boolean_true_node)
warning ("comparison is always 1 due to limited range of data type");
warning ("comparison is always true due to limited range of data type");
}
if (val != 0)
@ -2589,7 +2589,7 @@ shorten_compare (op0_ptr, op1_ptr, restype_ptr, rescode_ptr)
&& ! (TREE_CODE (primop0) == INTEGER_CST
&& ! TREE_OVERFLOW (convert (signed_type (type),
primop0))))
warning ("unsigned value >= 0 is always 1");
warning ("comparison of unsigned expression >= 0 is always true");
value = boolean_true_node;
break;
@ -2598,7 +2598,7 @@ shorten_compare (op0_ptr, op1_ptr, restype_ptr, rescode_ptr)
&& ! (TREE_CODE (primop0) == INTEGER_CST
&& ! TREE_OVERFLOW (convert (signed_type (type),
primop0))))
warning ("unsigned value < 0 is always 0");
warning ("comparison of unsigned expression < 0 is always false");
value = boolean_false_node;
break;