mirror/gcc
2
0
Fork 0
mirror of git://gcc.gnu.org/git/gcc.git synced 2025-04-15 14:01:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

tree-optimization/103489 - fix ICE when bool pattern recog fails

Browse Source 
bool pattern recog currently does not handle cycles correctly
and when it fails we can ICE later vectorizing PHIs with
mismatched bool and non-bool vector types.  The following avoids
blindly trusting bool pattern recog here and verifies things
more thoroughly in vectorizable_phi.  A bool pattern recog fix
is for GCC 13.

2021-11-30  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/103489
	* tree-vect-loop.c (vectorizable_phi): Verify argument
	vector type compatibility to mitigate bool pattern recog
	bug.

	* gcc.dg/torture/pr103489.c: New testcase.
This commit is contained in:
Richard Biener 2021-11-30 14:08:19 +01:00
parent 7e846b0f13
commit 0194d92c35
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gcc/testsuite/gcc.dg/torture/pr103489.c Normal file
View File

@ -0,0 +1,12 @@
/* { dg-do compile } */
/* { dg-additional-options "-ftree-vectorize" } */
_Bool a[80];
short b, f;
void g(short h[][8][16])
{
for (_Bool c = 0; c < b;)
for (_Bool d = 0; d < (_Bool)f; d = 1)
for (short e = 0; e < 16; e++)
a[e] = h[b][1][e];
}

18
gcc/tree-vect-loop.c
View File

@ -7846,6 +7846,24 @@ vectorizable_phi (vec_info *,
"incompatible vector types for invariants\n");
return false;
}
else if (SLP_TREE_DEF_TYPE (child) == vect_internal_def
&& !useless_type_conversion_p (vectype,
SLP_TREE_VECTYPE (child)))
{
/* With bools we can have mask and non-mask precision vectors,
while pattern recog is supposed to guarantee consistency here
bugs in it can cause mismatches (PR103489 for example).
Deal with them here instead of ICEing later. */
if (dump_enabled_p ())
dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
"incompatible vector type setup from "
"bool pattern detection\n");
gcc_checking_assert
(VECTOR_BOOLEAN_TYPE_P (SLP_TREE_VECTYPE (child))
!= VECTOR_BOOLEAN_TYPE_P (vectype));
return false;
}
/* For single-argument PHIs assume coalescing which means zero cost
for the scalar and the vector PHIs. This avoids artificially
favoring the vector path (but may pessimize it in some cases). */