mirror/element-plus
2
0
Fork 0
mirror of https://github.com/element-plus/element-plus.git synced 2024-11-21 01:02:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(style): remove chinese comments in checkbox (#4189)

Browse Source
This commit is contained in:
云游君 2021-11-04 10:04:38 +08:00 committed by GitHub
parent b4d54b6e55
commit f548bcb8b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
DEV_FAQ.md
View File

@ -25,3 +25,11 @@ pnpm link --global element-plus
```
> More info see [pnpm link](https://pnpm.io/cli/link).
## Theme
We should not write Chinese comments in scss files.
It will generate warning `@charset "UTF-8";` in the header of css file when built with vite.
> More info see [#3219](https://github.com/element-plus/element-plus/issues/3219).

2
packages/theme-chalk/src/checkbox.scss
View File

@ -180,7 +180,7 @@ $checkbox-bordered-input-width: map.merge(
}
}
@include when(focus) {
/*focus时 视觉上区分*/
// Visually distinguish when focus
.#{$namespace}-checkbox__inner {
border-color: var(--el-checkbox-input-border-color-hover);
}