From dbfcdcf361e08b2c60d91899dda5fef6f05ac7ac Mon Sep 17 00:00:00 2001
From: kooriookami <38392315+kooriookami@users.noreply.github.com>
Date: Fri, 11 Jun 2021 18:28:50 +0800
Subject: [PATCH] perf(rate): update change event (#2181)

* perf(rate): update change event

re #2178

* perf: add test
---
 packages/rate/__tests__/rate.spec.ts | 33 ++++++++++++++++++++++++++++
 packages/rate/src/index.vue          | 14 ++++++++----
 2 files changed, 43 insertions(+), 4 deletions(-)

diff --git a/packages/rate/__tests__/rate.spec.ts b/packages/rate/__tests__/rate.spec.ts
index 9030bcb30b..7274d30f92 100644
--- a/packages/rate/__tests__/rate.spec.ts
+++ b/packages/rate/__tests__/rate.spec.ts
@@ -107,4 +107,37 @@ describe('Rate.vue', () => {
 
     expect(thirdStar.style.color).toEqual('rgb(255, 153, 0)')
   })
+
+  test('change event', () => {
+    const wrapper = mount({
+      template: `
+        <div>
+          <el-rate v-model="value" @change="handleChange"></el-rate>
+        </div>
+      `,
+      data() {
+        return {
+          value: 4,
+          changeCount: 0,
+        }
+      },
+      methods:{
+        handleChange() {
+          this.changeCount++
+        },
+      },
+      components: {
+        'el-rate': Rate,
+      },
+    })
+    const vm = wrapper.vm
+    const fourthStar = wrapper.findAll('.el-rate__item')[3].element as HTMLElement
+    fourthStar.click()
+    expect(vm.value).toEqual(4)
+    expect(vm.changeCount).toEqual(0)
+    const fifthStar = wrapper.findAll('.el-rate__item')[4].element as HTMLElement
+    fifthStar.click()
+    expect(vm.value).toEqual(5)
+    expect(vm.changeCount).toEqual(1)
+  })
 })
diff --git a/packages/rate/src/index.vue b/packages/rate/src/index.vue
index 308a393c3f..b37737da5b 100644
--- a/packages/rate/src/index.vue
+++ b/packages/rate/src/index.vue
@@ -116,7 +116,7 @@ export default defineComponent({
     },
     texts: {
       type: Array as PropType<string[]>,
-      default: () => ['Extremely bad','Disappointed','Fair','Satisfied','Surprise'],
+      default: () => ['Extremely bad', 'Disappointed', 'Fair', 'Satisfied', 'Surprise'],
     },
     scoreTemplate: {
       type: String,
@@ -157,6 +157,7 @@ export default defineComponent({
       const matchedValue = map[matchedKeys[0]]
       return isObject(matchedValue) ? matchedValue.value : (matchedValue || '')
     }
+
     const valueDecimal = computed(() => props.modelValue * 100 - Math.floor(props.modelValue) * 100)
     const colorMap = computed(() => isArray(props.colors)
       ? {
@@ -169,7 +170,7 @@ export default defineComponent({
     const decimalStyle = computed(() => {
       let width = ''
       if (rateDisabled.value) {
-        width = `${ valueDecimal.value }%`
+        width = `${valueDecimal.value}%`
       } else if (props.allowHalf) {
         width = '50%'
       }
@@ -229,10 +230,14 @@ export default defineComponent({
       }
       if (props.allowHalf && pointerAtLeftHalf.value) {
         emit('update:modelValue', currentValue.value)
-        emit('change', currentValue.value)
+        if (props.modelValue !== currentValue.value) {
+          emit('change', currentValue.value)
+        }
       } else {
         emit('update:modelValue', value)
-        emit('change', value)
+        if (props.modelValue !== value) {
+          emit('change', value)
+        }
       }
     }
 
@@ -267,6 +272,7 @@ export default defineComponent({
     }
 
     const hoverIndex = ref(-1)
+
     function setCurrentValue(value: number, event: MouseEvent) {
       if (rateDisabled.value) {
         return