From 806352d8443b94417b1dfe863738f0edb278b5a1 Mon Sep 17 00:00:00 2001 From: Christoph Hertzberg Date: Fri, 23 Nov 2018 12:34:27 +0000 Subject: [PATCH 1/2] Small typo found be Patrick Huber (pull request PR-547) --- doc/TutorialSlicingIndexing.dox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/TutorialSlicingIndexing.dox b/doc/TutorialSlicingIndexing.dox index 3b60eac6e..98ace43e4 100644 --- a/doc/TutorialSlicingIndexing.dox +++ b/doc/TutorialSlicingIndexing.dox @@ -2,7 +2,7 @@ namespace Eigen { /** \eigenManualPage TutorialSlicingIndexing Slicing and Indexing -This pape presents the numerous possibilities offered by `operator()` to index sub-set of rows and columns. +This page presents the numerous possibilities offered by `operator()` to index sub-set of rows and columns. This API has been introduced in %Eigen 3.4. It supports all the feature proposed by the \link TutorialBlockOperations block API \endlink, and much more. In particular, it supports \b slicing that consists in taking a set of rows, columns, or elements, uniformly spaced within a matrix or indexed from an array of indices. From ea60a172cf1c2b82d3d9b43a57e5a8ad391f1bdf Mon Sep 17 00:00:00 2001 From: Christoph Hertzberg Date: Fri, 23 Nov 2018 14:24:22 +0100 Subject: [PATCH 2/2] Add default constructor to Bar to make test compile again with clang-3.8 --- test/jacobisvd.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/jacobisvd.cpp b/test/jacobisvd.cpp index 41fd0631f..505bf57ae 100644 --- a/test/jacobisvd.cpp +++ b/test/jacobisvd.cpp @@ -70,7 +70,9 @@ void jacobisvd_method() } namespace Foo { -class Bar {}; +// older compiler require a default constructor for Bar +// cf: https://stackoverflow.com/questions/7411515/ +class Bar {public: Bar() {}}; bool operator<(const Bar&, const Bar&) { return true; } } // regression test for a very strange MSVC issue for which simply