mirror of
https://gitlab.com/libeigen/eigen.git
synced 2025-01-30 17:40:05 +08:00
argh, gael you're more clever than i remembered. diagonal product is
optimized. so, i almost revert, just reordering to reduce # of load/store.
This commit is contained in:
parent
d3529e9c40
commit
bf31d81aac
@ -388,7 +388,7 @@ Transform<Scalar,Dim>::fromPositionOrientationScale(const MatrixBase<PositionDer
|
||||
const OrientationType& orientation, const MatrixBase<ScaleDerived> &scale)
|
||||
{
|
||||
linear() = ToRotationMatrix<Scalar,Dim,OrientationType>::convert(orientation);
|
||||
for(int i = 0; i < Dim; i++) linear().col(i) *= scale.coeff(i);
|
||||
linear() *= scale.asDiagonal();
|
||||
translation() = position;
|
||||
m_matrix(Dim,Dim) = 1.;
|
||||
m_matrix.template block<1,Dim>(Dim,0).setZero();
|
||||
|
Loading…
Reference in New Issue
Block a user