mirror/eigen
2
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-02-05 17:50:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug #894: the sign of LDLT was not re-initialized at each call of compute()

Browse Source 
(grafted from d04f23260d
)
This commit is contained in:
Gael Guennebaud 2014-10-20 10:48:40 +02:00
parent 235c97ba92
commit a72eabec9b
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Eigen/src/Cholesky/LDLT.h
View File

@ -442,6 +442,7 @@ LDLT<MatrixType,_UpLo>& LDLT<MatrixType,_UpLo>::compute(const MatrixType& a)
m_transpositions.resize(size); m_transpositions.resize(size);
m_isInitialized = false; m_isInitialized = false;
m_temporary.resize(size); m_temporary.resize(size);
m_sign = internal::ZeroSign;
internal::ldlt_inplace<UpLo>::unblocked(m_matrix, m_transpositions, m_temporary, m_sign); internal::ldlt_inplace<UpLo>::unblocked(m_matrix, m_transpositions, m_temporary, m_sign);

12
test/cholesky.cpp
View File

@ -320,33 +320,35 @@ template<typename MatrixType> void cholesky_definiteness(const MatrixType& m)
{ {
eigen_assert(m.rows() == 2 && m.cols() == 2); eigen_assert(m.rows() == 2 && m.cols() == 2);
MatrixType mat; MatrixType mat;
LDLT<MatrixType> ldlt(2);
{ {
mat << 1, 0, 0, -1; mat << 1, 0, 0, -1;
LDLT<MatrixType> ldlt(mat); ldlt.compute(mat);
VERIFY(!ldlt.isNegative()); VERIFY(!ldlt.isNegative());
VERIFY(!ldlt.isPositive()); VERIFY(!ldlt.isPositive());
} }
{ {
mat << 1, 2, 2, 1; mat << 1, 2, 2, 1;
LDLT<MatrixType> ldlt(mat); ldlt.compute(mat);
VERIFY(!ldlt.isNegative()); VERIFY(!ldlt.isNegative());
VERIFY(!ldlt.isPositive()); VERIFY(!ldlt.isPositive());
} }
{ {
mat << 0, 0, 0, 0; mat << 0, 0, 0, 0;
LDLT<MatrixType> ldlt(mat); ldlt.compute(mat);
VERIFY(ldlt.isNegative()); VERIFY(ldlt.isNegative());
VERIFY(ldlt.isPositive()); VERIFY(ldlt.isPositive());
} }
{ {
mat << 0, 0, 0, 1; mat << 0, 0, 0, 1;
LDLT<MatrixType> ldlt(mat); ldlt.compute(mat);
VERIFY(!ldlt.isNegative()); VERIFY(!ldlt.isNegative());
VERIFY(ldlt.isPositive()); VERIFY(ldlt.isPositive());
} }
{ {
mat << -1, 0, 0, 0; mat << -1, 0, 0, 0;
LDLT<MatrixType> ldlt(mat); ldlt.compute(mat);
VERIFY(ldlt.isNegative()); VERIFY(ldlt.isNegative());
VERIFY(!ldlt.isPositive()); VERIFY(!ldlt.isPositive());
} }