mirror/eigen
2
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-03-13 18:37:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix bug in the computation of rank

Browse Source 
very difficult to catch in unit-tests because this is very noisy
This commit is contained in:
Benoit Jacob 2009-01-20 16:21:56 +00:00
parent 3134d5290b
commit 81cb887baf
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Eigen/src/LU/LU.h
View File

@ -401,9 +401,11 @@ LU<MatrixType>::LU(const MatrixType& matrix)
m_det_pq = (number_of_transpositions%2) ? -1 : 1;
for(m_rank = 0; m_rank < size; ++m_rank)
if(ei_isMuchSmallerThan(m_lu.diagonal().coeff(m_rank), m_lu.diagonal().coeff(0)))
break;
RealScalar biggest_diagonal_coeff = m_lu.diagonal().cwise().abs().maxCoeff();
m_rank = 0;
for(int k = 0; k < size; ++k)
if(!ei_isMuchSmallerThan(m_lu.diagonal().coeff(k), biggest_diagonal_coeff))
++m_rank;
}
template<typename MatrixType>