diff --git a/Eigen/src/Core/GlobalFunctions.h b/Eigen/src/Core/GlobalFunctions.h index 90d6b6e28..aaa076701 100644 --- a/Eigen/src/Core/GlobalFunctions.h +++ b/Eigen/src/Core/GlobalFunctions.h @@ -14,7 +14,7 @@ #define EIGEN_ARRAY_DECLARE_GLOBAL_UNARY(NAME,FUNCTOR) \ template \ inline const Eigen::CwiseUnaryOp, const Derived> \ - NAME(const Eigen::ArrayBase& x) { \ + (NAME)(const Eigen::ArrayBase& x) { \ return Eigen::CwiseUnaryOp, const Derived>(x.derived()); \ } diff --git a/Eigen/src/Core/MathFunctions.h b/Eigen/src/Core/MathFunctions.h index f2d5b4879..6aa062198 100644 --- a/Eigen/src/Core/MathFunctions.h +++ b/Eigen/src/Core/MathFunctions.h @@ -788,7 +788,7 @@ bool (isfinite)(const T& x) { #if EIGEN_HAS_CXX11_MATH using std::isfinite; - return isfinite(x); + return isfinite EIGEN_NOT_A_MACRO (x); #else return x::highest() && x>NumTraits::lowest(); #endif @@ -800,7 +800,7 @@ bool (isnan)(const T& x) { #if EIGEN_HAS_CXX11_MATH using std::isnan; - return isnan(x); + return isnan EIGEN_NOT_A_MACRO (x); #else return x != x; #endif @@ -812,7 +812,7 @@ bool (isinf)(const T& x) { #if EIGEN_HAS_CXX11_MATH using std::isinf; - return isinf(x); + return isinf EIGEN_NOT_A_MACRO (x); #else return x>NumTraits::highest() || x::lowest(); #endif @@ -821,19 +821,19 @@ bool (isinf)(const T& x) template bool (isfinite)(const std::complex& x) { - return numext::isfinite(numext::real(x)) && numext::isfinite(numext::imag(x)); + return (numext::isfinite)(numext::real(x)) && (numext::isfinite)(numext::imag(x)); } template bool (isnan)(const std::complex& x) { - return numext::isnan(numext::real(x)) || numext::isnan(numext::imag(x)); + return (numext::isnan)(numext::real(x)) || (numext::isnan)(numext::imag(x)); } template bool (isinf)(const std::complex& x) { - return (numext::isinf(numext::real(x)) || numext::isinf(numext::imag(x))) && (!numext::isnan(x)); + return ((numext::isinf)(numext::real(x)) || (numext::isinf)(numext::imag(x))) && (!(numext::isnan)(x)); } template diff --git a/Eigen/src/Core/functors/UnaryFunctors.h b/Eigen/src/Core/functors/UnaryFunctors.h index 9b4f49c3c..260e8f834 100644 --- a/Eigen/src/Core/functors/UnaryFunctors.h +++ b/Eigen/src/Core/functors/UnaryFunctors.h @@ -591,7 +591,7 @@ struct functor_traits > template struct scalar_isnan_op { EIGEN_EMPTY_STRUCT_CTOR(scalar_isnan_op) typedef bool result_type; - EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE result_type operator() (const Scalar& a) const { return numext::isnan(a); } + EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE result_type operator() (const Scalar& a) const { return (numext::isnan)(a); } }; template struct functor_traits > @@ -609,7 +609,7 @@ struct functor_traits > template struct scalar_isinf_op { EIGEN_EMPTY_STRUCT_CTOR(scalar_isinf_op) typedef bool result_type; - EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE result_type operator() (const Scalar& a) const { return numext::isinf(a); } + EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE result_type operator() (const Scalar& a) const { return (numext::isinf)(a); } }; template struct functor_traits > @@ -627,7 +627,7 @@ struct functor_traits > template struct scalar_isfinite_op { EIGEN_EMPTY_STRUCT_CTOR(scalar_isfinite_op) typedef bool result_type; - EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE result_type operator() (const Scalar& a) const { return numext::isfinite(a); } + EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE result_type operator() (const Scalar& a) const { return (numext::isfinite)(a); } }; template struct functor_traits > diff --git a/test/array.cpp b/test/array.cpp index 3d00d1d2d..9f61c4b26 100644 --- a/test/array.cpp +++ b/test/array.cpp @@ -221,9 +221,9 @@ template void array_real(const ArrayType& m) VERIFY_IS_APPROX(m1.round(), round(m1)); VERIFY_IS_APPROX(m1.floor(), floor(m1)); VERIFY_IS_APPROX(m1.ceil(), ceil(m1)); - VERIFY((m1.isNaN() == Eigen::isnan(m1)).all()); - VERIFY((m1.isInf() == Eigen::isinf(m1)).all()); - VERIFY((m1.isFinite() == Eigen::isfinite(m1)).all()); + VERIFY((m1.isNaN() == (Eigen::isnan)(m1)).all()); + VERIFY((m1.isInf() == (Eigen::isinf)(m1)).all()); + VERIFY((m1.isFinite() == (Eigen::isfinite)(m1)).all()); VERIFY_IS_APPROX(m1.inverse(), inverse(m1)); VERIFY_IS_APPROX(m1.abs(), abs(m1)); VERIFY_IS_APPROX(m1.abs2(), abs2(m1)); @@ -249,9 +249,9 @@ template void array_real(const ArrayType& m) VERIFY_IS_APPROX(tanh(m1), (0.5*(exp(m1)-exp(-m1)))/(0.5*(exp(m1)+exp(-m1)))); VERIFY_IS_APPROX(arg(m1), ((ArrayType)(m1<0))*std::acos(-1.0)); VERIFY((round(m1) <= ceil(m1) && round(m1) >= floor(m1)).all()); - VERIFY(Eigen::isnan((m1*0.0)/0.0).all()); - VERIFY(Eigen::isinf(m4/0.0).all()); - VERIFY((Eigen::isfinite(m1) && (!Eigen::isfinite(m1*0.0/0.0)) && (!Eigen::isfinite(m4/0.0))).all()); + VERIFY((Eigen::isnan)((m1*0.0)/0.0).all()); + VERIFY((Eigen::isinf)(m4/0.0).all()); + VERIFY(((Eigen::isfinite)(m1) && (!(Eigen::isfinite)(m1*0.0/0.0)) && (!(Eigen::isfinite)(m4/0.0))).all()); VERIFY_IS_APPROX(inverse(inverse(m1)),m1); VERIFY((abs(m1) == m1 || abs(m1) == -m1).all()); VERIFY_IS_APPROX(m3, sqrt(abs2(m1))); @@ -336,9 +336,9 @@ template void array_complex(const ArrayType& m) VERIFY_IS_APPROX(m1.cosh(), cosh(m1)); VERIFY_IS_APPROX(m1.tanh(), tanh(m1)); VERIFY_IS_APPROX(m1.arg(), arg(m1)); - VERIFY((m1.isNaN() == Eigen::isnan(m1)).all()); - VERIFY((m1.isInf() == Eigen::isinf(m1)).all()); - VERIFY((m1.isFinite() == Eigen::isfinite(m1)).all()); + VERIFY((m1.isNaN() == (Eigen::isnan)(m1)).all()); + VERIFY((m1.isInf() == (Eigen::isinf)(m1)).all()); + VERIFY((m1.isFinite() == (Eigen::isfinite)(m1)).all()); VERIFY_IS_APPROX(m1.inverse(), inverse(m1)); VERIFY_IS_APPROX(m1.log(), log(m1)); VERIFY_IS_APPROX(m1.log10(), log10(m1)); @@ -364,20 +364,20 @@ template void array_complex(const ArrayType& m) VERIFY_IS_APPROX(arg(m1), m3); std::complex zero(0.0,0.0); - VERIFY(Eigen::isnan(m1*zero/zero).all()); + VERIFY((Eigen::isnan)(m1*zero/zero).all()); #if EIGEN_COMP_CLANG // clang's complex division is notoriously broken - if(numext::isinf(m4(0,0)/RealScalar(0))) { + if((numext::isinf)(m4(0,0)/RealScalar(0))) { #endif - VERIFY(Eigen::isinf(m4/zero).all()); + VERIFY((Eigen::isinf)(m4/zero).all()); #if EIGEN_COMP_CLANG } else { - VERIFY(Eigen::isinf(m4.real()/zero.real()).all()); + VERIFY((Eigen::isinf)(m4.real()/zero.real()).all()); } #endif - VERIFY((Eigen::isfinite(m1) && (!Eigen::isfinite(m1*zero/zero)) && (!Eigen::isfinite(m1/zero))).all()); + VERIFY(((Eigen::isfinite)(m1) && (!(Eigen::isfinite)(m1*zero/zero)) && (!(Eigen::isfinite)(m1/zero))).all()); VERIFY_IS_APPROX(inverse(inverse(m1)),m1); VERIFY_IS_APPROX(conj(m1.conjugate()), m1); diff --git a/test/main.h b/test/main.h index 0d03d4853..2797e8623 100644 --- a/test/main.h +++ b/test/main.h @@ -55,6 +55,9 @@ // compiler error. #define min(A,B) please_protect_your_min_with_parentheses #define max(A,B) please_protect_your_max_with_parentheses +#define isnan(X) please_protect_your_isnan_with_parentheses +#define isinf(X) please_protect_your_isinf_with_parentheses +#define isfinite(X) please_protect_your_isfinite_with_parentheses #define FORBIDDEN_IDENTIFIER (this_identifier_is_forbidden_to_avoid_clashes) this_identifier_is_forbidden_to_avoid_clashes // B0 is defined in POSIX header termios.h