mirror/eigen
2
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2024-12-15 07:10:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make is_convertible more robust and conformant to std::is_convertible

Browse Source
This commit is contained in:
Gael Guennebaud 2018-07-12 09:57:19 +02:00
parent 8a5955a052
commit 21cf4a1a8b
2 changed files with 36 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Eigen/src/Core/util/Meta.h
View File

@ -145,16 +145,19 @@ private:
struct yes {int a[1];}; struct yes {int a[1];};
struct no {int a[2];}; struct no {int a[2];};
static yes test(const To&, int); template<typename T>
static yes test(T, int);
template<typename T>
static no test(any_conversion, ...); static no test(any_conversion, ...);
public: public:
static From ms_from; static From* ms_from;
#ifdef __INTEL_COMPILER #ifdef __INTEL_COMPILER
#pragma warning push #pragma warning push
#pragma warning ( disable : 2259 ) #pragma warning ( disable : 2259 )
#endif #endif
enum { value = sizeof(test(ms_from, 0))==sizeof(yes) }; enum { value = sizeof(test<To>(*ms_from, 0))==sizeof(yes) };
#ifdef __INTEL_COMPILER #ifdef __INTEL_COMPILER
#pragma warning pop #pragma warning pop
#endif #endif
@ -163,8 +166,7 @@ public:
template<typename From, typename To> template<typename From, typename To>
struct is_convertible struct is_convertible
{ {
enum { value = is_convertible_impl<typename remove_all<From>::type, enum { value = is_convertible_impl<From,To>::value };
typename remove_all<To >::type>::value };
}; };
/** \internal Allows to enable/disable an overload /** \internal Allows to enable/disable an overload

36
test/meta.cpp
View File

@ -19,6 +19,14 @@ struct FooReturnType {
typedef int ReturnType; typedef int ReturnType;
}; };
struct MyInterface {
virtual void func() = 0;
virtual ~MyInterface() {}
};
struct MyImpl : public MyInterface {
void func() {}
};
void test_meta() void test_meta()
{ {
VERIFY((internal::conditional<(3<4),internal::true_type, internal::false_type>::type::value)); VERIFY((internal::conditional<(3<4),internal::true_type, internal::false_type>::type::value));
@ -62,14 +70,19 @@ void test_meta()
VERIFY(( internal::is_same<const float,internal::remove_pointer<const float*>::type >::value)); VERIFY(( internal::is_same<const float,internal::remove_pointer<const float*>::type >::value));
VERIFY(( internal::is_same<float,internal::remove_pointer<float* const >::type >::value)); VERIFY(( internal::is_same<float,internal::remove_pointer<float* const >::type >::value));
VERIFY(( internal::is_convertible<float,double>::value ));
VERIFY(( internal::is_convertible<int,double>::value )); // is_convertible
VERIFY(( internal::is_convertible<double,int>::value )); STATIC_CHECK(( internal::is_convertible<float,double>::value ));
VERIFY((!internal::is_convertible<std::complex<double>,double>::value )); STATIC_CHECK(( internal::is_convertible<int,double>::value ));
VERIFY(( internal::is_convertible<Array33f,Matrix3f>::value )); STATIC_CHECK(( internal::is_convertible<int, short>::value ));
STATIC_CHECK(( internal::is_convertible<short, int>::value ));
STATIC_CHECK(( internal::is_convertible<double,int>::value ));
STATIC_CHECK(( internal::is_convertible<double,std::complex<double> >::value ));
STATIC_CHECK((!internal::is_convertible<std::complex<double>,double>::value ));
STATIC_CHECK(( internal::is_convertible<Array33f,Matrix3f>::value ));
// VERIFY((!internal::is_convertible<Matrix3f,Matrix3d>::value )); //does not work because the conversion is prevented by a static assertion // VERIFY((!internal::is_convertible<Matrix3f,Matrix3d>::value )); //does not work because the conversion is prevented by a static assertion
VERIFY((!internal::is_convertible<Array33f,int>::value )); STATIC_CHECK((!internal::is_convertible<Array33f,int>::value ));
VERIFY((!internal::is_convertible<MatrixXf,float>::value )); STATIC_CHECK((!internal::is_convertible<MatrixXf,float>::value ));
{ {
float f; float f;
MatrixXf A, B; MatrixXf A, B;
@ -80,6 +93,15 @@ void test_meta()
VERIFY(( check_is_convertible(A*B, A) )); VERIFY(( check_is_convertible(A*B, A) ));
} }
STATIC_CHECK(( !internal::is_convertible<MyInterface, MyImpl>::value ));
STATIC_CHECK(( !internal::is_convertible<MyImpl, MyInterface>::value ));
STATIC_CHECK(( internal::is_convertible<MyImpl, const MyInterface&>::value ));
{
int i;
VERIFY(( check_is_convertible(fix<3>(), i) ));
VERIFY((!check_is_convertible(i, fix<DynamicIndex>()) ));
}
VERIFY(( internal::has_ReturnType<FooReturnType>::value )); VERIFY(( internal::has_ReturnType<FooReturnType>::value ));
VERIFY(( internal::has_ReturnType<ScalarBinaryOpTraits<int,int> >::value )); VERIFY(( internal::has_ReturnType<ScalarBinaryOpTraits<int,int> >::value ));
VERIFY(( !internal::has_ReturnType<MatrixXf>::value )); VERIFY(( !internal::has_ReturnType<MatrixXf>::value ));