make UpperBidiagonalization internal: don't want to support it, it's not used.

Keeping it because it tests BandMatrix.
This commit is contained in:
Benoit Jacob 2010-11-23 11:12:42 -05:00
parent ee38dbf1e6
commit 0ab9a0a2f7
3 changed files with 6 additions and 13 deletions

View File

@ -25,6 +25,10 @@
#ifndef EIGEN_BIDIAGONALIZATION_H
#define EIGEN_BIDIAGONALIZATION_H
namespace internal {
// UpperBidiagonalization will probably be replaced by a Bidiagonalization class, don't want to make it stable API.
// At the same time, it's useful to keep for now as it's about the only thing that is testing the BandMatrix class.
template<typename _MatrixType> class UpperBidiagonalization
{
public:
@ -149,5 +153,6 @@ MatrixBase<Derived>::bidiagonalization() const
}
#endif
} // end namespace internal
#endif // EIGEN_BIDIAGONALIZATION_H

View File

@ -197,18 +197,6 @@ namespace Eigen {
<td>-</td>
</tr>
<tr>
<td>UpperBidiagonalization</td>
<td>Rows >= columns</td>
<td>Fast</td>
<td>Good</td>
<td>-</td>
<td>-</td>
<td>-</td>
<td>Good</td>
<td>-</td>
</tr>
<tr class="alt">
<td>Tridiagonalization</td>
<td>Self-adjoint</td>

View File

@ -34,7 +34,7 @@ template<typename MatrixType> void upperbidiag(const MatrixType& m)
typedef Matrix<typename MatrixType::RealScalar, MatrixType::RowsAtCompileTime, MatrixType::ColsAtCompileTime> RealMatrixType;
MatrixType a = MatrixType::Random(rows,cols);
UpperBidiagonalization<MatrixType> ubd(a);
internal::UpperBidiagonalization<MatrixType> ubd(a);
RealMatrixType b(rows, cols);
b.setZero();
b.block(0,0,cols,cols) = ubd.bidiagonal();