mirror of
https://github.com/curl/curl.git
synced 2024-12-15 06:40:09 +08:00
fb711b5098
- appveyor: add build-only job for clang-cl. - cmake: `-pedantic-errors` enables `-Werror,-Wlanguage-extension-token` automatically, which makes `__int64` detection fail. Explictly disable this compiler warning for clang-cl to make the feature detection work and to accept `__int64` in the source code. - cmake: disable `-Wlanguage-extension-token` warning for clang-cl to fix these when encountering `__int64`: ``` lib/formdata.c(797,29): error : extension used [-Werror,-Wlanguage-extension-token] lib/warnless.c(117,33): error : extension used [-Werror,-Wlanguage-extension-token] lib/warnless.c(60,28): message : expanded from macro 'CURL_MASK_SCOFFT' lib/warnless.c(59,38): message : expanded from macro 'CURL_MASK_UCOFFT' include\curl/system.h(352,40): message : expanded from macro 'CURL_TYPEOF_CURL_OFF_T' ``` - make `__GNUC__` warning suppressions apply to `__clang__` too. Necessary for clang-cl, which defines the latter, but not the former. (Regular clang defines both.) - examples: fix clang-cl compiler warning in `http2-upload.c`. ``` docs\examples\http2-upload.c(56,5): error : no previous prototype for function 'my_gettimeofday' [-Werror,-Wmissing-prototypes] docs\examples\http2-upload.c(56,1): message : declare 'static' if the function is not intended to be used outside of this translation unit ``` - unit2604: add missing `#pragma GCC diagnostic pop`. Follow-up toe53523fef0
#14859 - unit1652: limit compiler warning suppression to GCC. They do not affect clang builds. Follow-up to71cf0d1fca
#14772 Closes #15449
154 lines
4.8 KiB
C
154 lines
4.8 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
|
|
#include "urldata.h"
|
|
#include "sendf.h"
|
|
|
|
/*
|
|
* This test hardcodes the knowledge of the buffer size which is internal to
|
|
* Curl_infof(). If that buffer is changed in size, this tests needs to be
|
|
* updated to still be valid.
|
|
*/
|
|
|
|
static struct Curl_easy *testdata;
|
|
|
|
static char input[4096];
|
|
static char output[4096];
|
|
|
|
int debugf_cb(CURL *handle, curl_infotype type, char *buf, size_t size,
|
|
void *userptr);
|
|
|
|
/*
|
|
* This debugf callback is simply dumping the string into the static buffer
|
|
* for the unit test to inspect. Since we know that we're only dealing with
|
|
* text we can afford the luxury of skipping the type check here.
|
|
*/
|
|
int
|
|
debugf_cb(CURL *handle, curl_infotype type, char *buf, size_t size,
|
|
void *userptr)
|
|
{
|
|
(void)handle;
|
|
(void)type;
|
|
(void)userptr;
|
|
|
|
memset(output, '\0', sizeof(output));
|
|
memcpy(output, buf, size);
|
|
return 0;
|
|
}
|
|
|
|
static CURLcode
|
|
unit_setup(void)
|
|
{
|
|
CURLcode res = CURLE_OK;
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
testdata = curl_easy_init();
|
|
if(!testdata) {
|
|
curl_global_cleanup();
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
curl_easy_setopt(testdata, CURLOPT_DEBUGFUNCTION, debugf_cb);
|
|
curl_easy_setopt(testdata, CURLOPT_VERBOSE, 1L);
|
|
return res;
|
|
}
|
|
|
|
static void
|
|
unit_stop(void)
|
|
{
|
|
curl_easy_cleanup(testdata);
|
|
curl_global_cleanup();
|
|
}
|
|
|
|
static int verify(const char *info, const char *two)
|
|
{
|
|
/* the 'info' one has a newline appended */
|
|
char *nl = strchr(info, '\n');
|
|
if(!nl)
|
|
return 1; /* nope */
|
|
return strncmp(info, two, nl - info);
|
|
}
|
|
|
|
UNITTEST_START
|
|
|
|
#if defined(__GNUC__) && !defined(__clang__)
|
|
#pragma GCC diagnostic push
|
|
#pragma GCC diagnostic ignored "-Wformat"
|
|
#pragma GCC diagnostic ignored "-Wformat-zero-length"
|
|
#if __GNUC__ >= 7
|
|
#pragma GCC diagnostic ignored "-Wformat-overflow"
|
|
#endif
|
|
#endif
|
|
|
|
/* Injecting a simple short string via a format */
|
|
msnprintf(input, sizeof(input), "Simple Test");
|
|
Curl_infof(testdata, "%s", input);
|
|
fail_unless(verify(output, input) == 0, "Simple string test");
|
|
|
|
/* Injecting a few different variables with a format */
|
|
Curl_infof(testdata, "%s %u testing %lu", input, 42, 43L);
|
|
fail_unless(verify(output, "Simple Test 42 testing 43\n") == 0,
|
|
"Format string");
|
|
|
|
/* Variations of empty strings */
|
|
Curl_infof(testdata, "");
|
|
fail_unless(strlen(output) == 1, "Empty string");
|
|
Curl_infof(testdata, "%s", (char *)NULL);
|
|
fail_unless(verify(output, "(nil)") == 0, "Passing NULL as string");
|
|
|
|
/* A string just long enough to not be truncated */
|
|
memset(input, '\0', sizeof(input));
|
|
memset(input, 'A', 2047);
|
|
Curl_infof(testdata, "%s", input);
|
|
fail_unless(strlen(output) == 2048, "No truncation of infof input");
|
|
fail_unless(verify(output, input) == 0, "No truncation of infof input");
|
|
fail_unless(output[sizeof(output) - 1] == '\0',
|
|
"No truncation of infof input");
|
|
|
|
/* Just over the limit without newline for truncation via '...' */
|
|
memset(input + 2047, 'A', 4);
|
|
Curl_infof(testdata, "%s", input);
|
|
fail_unless(strlen(output) == 2051, "Truncation of infof input 1");
|
|
fail_unless(output[sizeof(output) - 1] == '\0', "Truncation of infof input 1");
|
|
|
|
/* Just over the limit with newline for truncation via '...' */
|
|
memset(input + 2047, 'A', 4);
|
|
memset(input + 2047 + 4, '\n', 1);
|
|
Curl_infof(testdata, "%s", input);
|
|
fail_unless(strlen(output) == 2051, "Truncation of infof input 2");
|
|
fail_unless(output[sizeof(output) - 1] == '\0', "Truncation of infof input 2");
|
|
|
|
/* Way over the limit for truncation via '...' */
|
|
memset(input, '\0', sizeof(input));
|
|
memset(input, 'A', sizeof(input) - 1);
|
|
Curl_infof(testdata, "%s", input);
|
|
fail_unless(strlen(output) == 2051, "Truncation of infof input 3");
|
|
fail_unless(output[sizeof(output) - 1] == '\0', "Truncation of infof input 3");
|
|
|
|
#if defined(__GNUC__) && !defined(__clang__)
|
|
#pragma GCC diagnostic pop
|
|
#endif
|
|
|
|
UNITTEST_STOP
|